From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support Date: Tue, 13 Feb 2018 16:41:51 +0100 Message-ID: <20180213154151.GC12578@pd.tnic> References: <20180212153715.87555-1-brijesh.singh@amd.com> <20180212153715.87555-6-brijesh.singh@amd.com> <20180212183803.GR13981@localhost.localdomain> <4a1f22d9-da2e-618b-1423-629817389948@amd.com> <20180212211948.GK14422@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Brijesh Singh , Eduardo Habkost , "Edgar E. Iglesias" , Peter Maydell , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Peter Crosthwaite , Richard Henderson , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Christian Borntraeger , Alexander Graf , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Thomas Lendacky , Alistair Francis Return-path: Received: from mx2.suse.de ([195.135.220.15]:35860 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933425AbeBMPmY (ORCPT ); Tue, 13 Feb 2018 10:42:24 -0500 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Feb 13, 2018 at 09:39:01AM -0600, Brijesh Singh wrote: > Yes, I think we should be able to avoid creating new CPU model to > handle this case. I am leaning towards dropping this patch and > implement logic to populate the CPUID 0x8000_001F only when SEV is > enabled. This should not require any changes in existing CPU model > feature flag and live migration of existing guest should work fine. That sounds even nicer. Thx. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --