From: David Hildenbrand <david@redhat.com>
To: kvm@vger.kernel.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"David Hildenbrand" <david@redhat.com>
Subject: [PATCH kvm-unit-tests v3 02/11] s390x: use highest addresses for PGM_ADDRESSING errors
Date: Tue, 13 Feb 2018 17:23:12 +0100 [thread overview]
Message-ID: <20180213162321.20522-3-david@redhat.com> (raw)
In-Reply-To: <20180213162321.20522-1-david@redhat.com>
Without the L, we get 32 bit addresses, resulting in different memory
addresses. This is necessary for enabling the MMU.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
s390x/intercept.c | 10 +++++-----
s390x/selftest.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/s390x/intercept.c b/s390x/intercept.c
index 99dde0d..404b4c6 100644
--- a/s390x/intercept.c
+++ b/s390x/intercept.c
@@ -46,7 +46,7 @@ static void test_stpx(void)
check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
expect_pgm_int();
- asm volatile(" stpx 0(%0) " : : "r"(-8));
+ asm volatile(" stpx 0(%0) " : : "r"(-8L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
@@ -78,7 +78,7 @@ static void test_spx(void)
check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
expect_pgm_int();
- asm volatile(" spx 0(%0) " : : "r"(-8));
+ asm volatile(" spx 0(%0) " : : "r"(-8L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
@@ -101,7 +101,7 @@ static void test_stap(void)
check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
expect_pgm_int();
- asm volatile ("stap 0(%0)\n" : : "r"(-8));
+ asm volatile ("stap 0(%0)\n" : : "r"(-8L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
@@ -126,7 +126,7 @@ static void test_stidp(void)
check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
expect_pgm_int();
- asm volatile ("stidp 0(%0)\n" : : "r"(-8));
+ asm volatile ("stidp 0(%0)\n" : : "r"(-8L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
@@ -155,7 +155,7 @@ static void test_testblock(void)
check_pgm_int_code(PGM_INT_CODE_PROTECTION);
expect_pgm_int();
- asm volatile (" .insn rre,0xb22c0000,0,%0\n" : : "r"(-4096));
+ asm volatile (" .insn rre,0xb22c0000,0,%0\n" : : "r"(-4096L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
diff --git a/s390x/selftest.c b/s390x/selftest.c
index 1c8d16a..905713f 100644
--- a/s390x/selftest.c
+++ b/s390x/selftest.c
@@ -33,7 +33,7 @@ static void test_pgm_int(void)
check_pgm_int_code(PGM_INT_CODE_OPERATION);
expect_pgm_int();
- asm volatile(" stg %0,0(%0)\n" : : "r"(-1));
+ asm volatile(" stg %0,0(%0)\n" : : "r"(-1L));
check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
}
--
2.14.3
next prev parent reply other threads:[~2018-02-13 16:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 16:23 [PATCH kvm-unit-tests v3 00/11] s390x: vmalloc support David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 01/11] s390x: fix TEST BLOCK tests David Hildenbrand
2018-02-13 16:23 ` David Hildenbrand [this message]
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 03/11] s390x: set initital stack pointer to stackptr, not stacktop David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 04/11] s390x: add missing sclp definitions from QEMU David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 05/11] s390x: rename sclp_setup() to sclp_ascii_setup() David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 06/11] s390x: detect installed memory David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 07/11] s390x: initialize the physical allocator David Hildenbrand
2018-02-14 12:05 ` Thomas Huth
2018-02-14 12:22 ` David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 08/11] s390x: add vmalloc support David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 09/11] s390x: enable DAT in PGM interrupt handler David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 10/11] s390x: add test for (v)malloc David Hildenbrand
2018-02-13 16:23 ` [PATCH kvm-unit-tests v3 11/11] s390x: add sieve test David Hildenbrand
2018-02-13 16:26 ` Christian Borntraeger
2018-02-13 16:44 ` Paolo Bonzini
2018-02-13 17:02 ` David Hildenbrand
2018-02-13 17:08 ` David Hildenbrand
2018-02-14 11:51 ` Paolo Bonzini
2018-02-14 12:56 ` David Hildenbrand
2018-02-14 13:15 ` David Hildenbrand
2018-02-13 17:09 ` David Hildenbrand
2018-02-14 11:52 ` [PATCH kvm-unit-tests v3 00/11] s390x: vmalloc support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213162321.20522-3-david@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox