From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: [PATCH kvm-unit-tests v3 02/11] s390x: use highest addresses for PGM_ADDRESSING errors Date: Tue, 13 Feb 2018 17:23:12 +0100 Message-ID: <20180213162321.20522-3-david@redhat.com> References: <20180213162321.20522-1-david@redhat.com> Cc: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Thomas Huth , Cornelia Huck , Christian Borntraeger , David Hildenbrand To: kvm@vger.kernel.org Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35626 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934644AbeBMQX1 (ORCPT ); Tue, 13 Feb 2018 11:23:27 -0500 In-Reply-To: <20180213162321.20522-1-david@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Without the L, we get 32 bit addresses, resulting in different memory addresses. This is necessary for enabling the MMU. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- s390x/intercept.c | 10 +++++----- s390x/selftest.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/s390x/intercept.c b/s390x/intercept.c index 99dde0d..404b4c6 100644 --- a/s390x/intercept.c +++ b/s390x/intercept.c @@ -46,7 +46,7 @@ static void test_stpx(void) check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); expect_pgm_int(); - asm volatile(" stpx 0(%0) " : : "r"(-8)); + asm volatile(" stpx 0(%0) " : : "r"(-8L)); check_pgm_int_code(PGM_INT_CODE_ADDRESSING); } @@ -78,7 +78,7 @@ static void test_spx(void) check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); expect_pgm_int(); - asm volatile(" spx 0(%0) " : : "r"(-8)); + asm volatile(" spx 0(%0) " : : "r"(-8L)); check_pgm_int_code(PGM_INT_CODE_ADDRESSING); } @@ -101,7 +101,7 @@ static void test_stap(void) check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); expect_pgm_int(); - asm volatile ("stap 0(%0)\n" : : "r"(-8)); + asm volatile ("stap 0(%0)\n" : : "r"(-8L)); check_pgm_int_code(PGM_INT_CODE_ADDRESSING); } @@ -126,7 +126,7 @@ static void test_stidp(void) check_pgm_int_code(PGM_INT_CODE_SPECIFICATION); expect_pgm_int(); - asm volatile ("stidp 0(%0)\n" : : "r"(-8)); + asm volatile ("stidp 0(%0)\n" : : "r"(-8L)); check_pgm_int_code(PGM_INT_CODE_ADDRESSING); } @@ -155,7 +155,7 @@ static void test_testblock(void) check_pgm_int_code(PGM_INT_CODE_PROTECTION); expect_pgm_int(); - asm volatile (" .insn rre,0xb22c0000,0,%0\n" : : "r"(-4096)); + asm volatile (" .insn rre,0xb22c0000,0,%0\n" : : "r"(-4096L)); check_pgm_int_code(PGM_INT_CODE_ADDRESSING); } diff --git a/s390x/selftest.c b/s390x/selftest.c index 1c8d16a..905713f 100644 --- a/s390x/selftest.c +++ b/s390x/selftest.c @@ -33,7 +33,7 @@ static void test_pgm_int(void) check_pgm_int_code(PGM_INT_CODE_OPERATION); expect_pgm_int(); - asm volatile(" stg %0,0(%0)\n" : : "r"(-1)); + asm volatile(" stg %0,0(%0)\n" : : "r"(-1L)); check_pgm_int_code(PGM_INT_CODE_ADDRESSING); } -- 2.14.3