From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Raspl Subject: [PATCH 0/6] tools/kvm_stat improvements Date: Wed, 14 Feb 2018 22:45:47 +0100 Message-ID: <20180214214553.96753-1-raspl@linux.vnet.ibm.com> Cc: pbonzini@redhat.com, rkrcmar@redhat.com, frankja@linux.vnet.ibm.com To: kvm@vger.kernel.org Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50688 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1031406AbeBNVqC (ORCPT ); Wed, 14 Feb 2018 16:46:02 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1ELiEKU093858 for ; Wed, 14 Feb 2018 16:46:02 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2g4u9u4eae-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 14 Feb 2018 16:46:02 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 Feb 2018 21:46:00 -0000 Sender: kvm-owner@vger.kernel.org List-ID: Some bugfixes (patches 1&2), simplifications (patch 4), plus rework that lays the basis for introducing a (hopefully) neater drilldown mode in patch 7. Note that in absence of any knowledge of the interdependencies of the events in debugfs on other platforms like x86, this new 'functionality' was only added for S390 for now. Adding other platforms would be easy enough, though. Furthermore note that the data passing between Providers and Stats is pretty much at its limit now - if we'd ever wanted to put in more attributes along with the event data passed from Providers to Stats, we should probably switch to passing more involved data structures with indicator flags, etc. Not sure if performance is a concern, but from a coding/maintaining point of view that's something we should consider in that case. Changes in v2: * Patch [1]: - Switched to single underscore prefixing for "private" methods. * Patch [4]: - Renamed methods to "tracepoint_is_child" and "debugfs_is_child" from "trc_is_child" et al. - Also, moved "child_events" and "pid" from DebugfsProvider and TracepointProvider up to "Provider". --- Stefan Raspl (6): tools/kvm_stat: mark private methods as such tools/kvm_stat: eliminate extra guest/pid selection dialog tools/kvm_stat: cache compiled regular expression tools/kvm_stat: separate drilldown and fields filtering tools/kvm_stat: group child events indented after parent tools/kvm_stat: print 'Total' line for multiple events only tools/kvm/kvm_stat/kvm_stat | 435 ++++++++++++++++++++++------------------ tools/kvm/kvm_stat/kvm_stat.txt | 4 +- 2 files changed, 246 insertions(+), 193 deletions(-) -- 2.13.5