From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v2 3/5] target/i386: Add support for CPUID_8000_001E for AMD Date: Wed, 28 Feb 2018 19:24:21 +0100 Message-ID: <20180228182420.GC8418@flask> References: <1519439425-27883-1-git-send-email-babu.moger@amd.com> <1519439425-27883-4-git-send-email-babu.moger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com, Gary.Hook@amd.com, qemu-devel@nongnu.org, pbonzini@redhat.com, pixo@polepetko.eu, rth@twiddle.net To: Babu Moger Return-path: Content-Disposition: inline In-Reply-To: <1519439425-27883-4-git-send-email-babu.moger@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org 2018-02-23 21:30-0500, Babu Moger: > From: Stanislav Lanci > > Populate threads/core_id/apic_ids/socket_id when CPUID_EXT3_TOPOEXT > feature is supported. This is required to support hyperthreading > feature on AMD CPUS. These are supported via CPUID_8000_001E extended > functions. > > Signed-off-by: Stanislav Lanci > Signed-off-by: Babu Moger > --- > target/i386/cpu.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index a5a480e..191e850 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -3666,6 +3666,14 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, > *edx = 0; > } > break; > + case 0x8000001E: > + if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) { > + *eax = cpu->apic_id; > + *ebx = (cs->nr_threads - 1) << 8 | cpu->core_id; Do we somewhere assert that AMD cannot have cpu->core_id > 255? (qemu does allow weird configurations.) Thanks. > + *ecx = cpu->socket_id; > + *edx = 0; > + } > + break; > case 0xC0000000: > *eax = env->cpuid_xlevel2; > *ebx = 0; > -- > 1.8.3.1 >