From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands Date: Thu, 8 Mar 2018 17:08:24 +0000 Message-ID: <20180308170824.GL4718@redhat.com> References: <20180308124901.83533-1-brijesh.singh@amd.com> <20180308124901.83533-29-brijesh.singh@amd.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "Edgar E. Iglesias" , Peter Maydell , Borislav Petkov , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Peter Crosthwaite , Richard Henderson , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Christian Borntraeger , Alexander Graf , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Thomas Lendacky , Alistair Francis , Bruce Rogers To: Brijesh Singh Return-path: Content-Disposition: inline In-Reply-To: <20180308124901.83533-29-brijesh.singh@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > Blacklist the following commands to fix the 'make check' failure. >=20 > query-sev-launch-measure: it returns meaninful data only when we launch > SEV guest otherwise the command returns an error. >=20 > query-sev: it return an error when SEV is not available on host (e.g no= n > X86 platform or KVM is disabled at the build time) >=20 > query-sev-capabilities: it returns an error when SEV feature is not > available on host machine. We generally expect 'make check' to succeed on every single patch in a series, so that 'git bisect' doesn't break. So you should add each command to the blacklist in the same commit that introduced the failure in the first place. >=20 > Cc: "Daniel P. Berrang=C3=A9" > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Reviewed-by: "Dr. David Alan Gilbert" > Signed-off-by: Brijesh Singh > --- > tests/qmp-test.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/tests/qmp-test.c b/tests/qmp-test.c > index 22445d9ec258..7470c6b754bc 100644 > --- a/tests/qmp-test.c > +++ b/tests/qmp-test.c > @@ -204,6 +204,11 @@ static bool query_is_blacklisted(const char *cmd) > "query-gic-capabilities", /* arm */ > /* Success depends on target-specific build configuration: */ > "query-pci", /* CONFIG_PCI */ > + /* Success depends on launching SEV guest */ > + "query-sev-launch-measure", > + /* Success depends on Host or Hypervisor SEV support */ > + "query-sev", > + "query-sev-capabilities", > NULL > }; > int i; > --=20 > 2.14.3 >=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|