From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. David Alan Gilbert" Subject: Re: [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands Date: Fri, 9 Mar 2018 10:12:01 +0000 Message-ID: <20180309101200.GB3213@work-vm> References: <20180308124901.83533-1-brijesh.singh@amd.com> <20180308124901.83533-29-brijesh.singh@amd.com> <20180308170824.GL4718@redhat.com> <20180308214504.GE3417@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "Edgar E. Iglesias" , Peter Maydell , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Stefan Hajnoczi , Peter Crosthwaite , Richard Henderson , qemu-devel@nongnu.org, Alistair Francis , Christian Borntraeger , Alexander Graf , Paolo Bonzini , Cornelia Huck , Brijesh Singh , Thomas Lendacky , Borislav Petkov , Bruce Rogers To: Eduardo Habkost Return-path: Content-Disposition: inline In-Reply-To: <20180308214504.GE3417@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org * Eduardo Habkost (ehabkost@redhat.com) wrote: > On Thu, Mar 08, 2018 at 02:18:55PM -0600, Brijesh Singh wrote: > >=20 > >=20 > > On 3/8/18 11:08 AM, Daniel P. Berrang=E9 wrote: > > > On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > > >> Blacklist the following commands to fix the 'make check' failure. > > >> > > >> query-sev-launch-measure: it returns meaninful data only when we l= aunch > > >> SEV guest otherwise the command returns an error. > > >> > > >> query-sev: it return an error when SEV is not available on host (e= .g non > > >> X86 platform or KVM is disabled at the build time) > > >> > > >> query-sev-capabilities: it returns an error when SEV feature is no= t > > >> available on host machine. > > > We generally expect 'make check' to succeed on every single patch > > > in a series, so that 'git bisect' doesn't break. > > > > > > So you should add each command to the blacklist in the same commit > > > that introduced the failure in the first place. > >=20 > >=20 > > Sure, I can quickly send the updated patch series to address your thi= s > > concern, but before spamming everyone's inbox I was wondering if I ca= n > > get some indication whether this series will make into 2.12 merge. > >=20 > > Paolo, Eduardo and Richard, > >=20 > > Most of the changes are in x86 directory hence any thought if you are > > considering this series for 2.12 ? I have been testing the series wit= h > > and without SEV support and so far have not ran into any issue. if yo= u > > are not planning to pull this series in 2.12 then I will wait a bit > > longer to get more feedback before sending the updates to address > > Daniel's comment. thanks >=20 > Trying to merge it before 2.12 soft freeze (next Tuesday) still > looks like a reasonable goal to me. What do others think? I've only looked at a few general comments and things but it looks like it's getting there; I don't think it's had many comments from the KVM side yet. Dave > --=20 > Eduardo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK