From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v4 7/7] x86/kvm: use Enlightened VMCS when running on Hyper-V Date: Fri, 16 Mar 2018 17:06:09 +0100 Message-ID: <20180316160609.GD5180@flask> References: <20180316142220.32506-1-vkuznets@redhat.com> <20180316142220.32506-8-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, x86@kernel.org, Paolo Bonzini , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "Michael Kelley (EOSG)" , Mohammed Gamal , Cathy Avery , Bandan Das , Thomas Gleixner , Christoph Hellwig , linux-kernel@vger.kernel.org To: Vitaly Kuznetsov Return-path: Content-Disposition: inline In-Reply-To: <20180316142220.32506-8-vkuznets@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2018-03-16 15:22+0100, Vitaly Kuznetsov: > Enlightened VMCS is just a structure in memory, the main benefit > besides avoiding somewhat slower VMREAD/VMWRITE is using clean field > mask: we tell the underlying hypervisor which fields were modified > since VMEXIT so there's no need to inspect them all. > > Tight CPUID loop test shows significant speedup: > Before: 18890 cycles > After: 8304 cycles > > Static key is being used to avoid performance penalty for non-Hyper-V > deployments. > > Signed-off-by: Vitaly Kuznetsov > --- Looks good, thanks. Reviewed-by: Radim Krčmář