From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Dmitry Fleytman <dmitry.fleytman@gmail.com>,
sheepdog@lists.wpkg.org,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
David Hildenbrand <david@redhat.com>,
Zhang Chen <zhangckid@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, BALATON Zoltan <balaton@eik.bme.hu>,
Keith Busch <keith.busch@intel.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Laurent Vivier <laurent@vivier.eu>,
Gerd Hoffmann <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Subbaraya Sundeep <sundeep.lkml@gmail.com>,
Yongbok Kim <yongbok.kim@mips.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
Ben Warren <ben@skyportsyst
Subject: Re: [PATCH] qemu: include generated files with <> and not ""
Date: Tue, 20 Mar 2018 18:51:02 +0200 [thread overview]
Message-ID: <20180320185013-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <da3457a0-7f24-4759-7d98-9b2fdc87e87c@redhat.com>
On Tue, Mar 20, 2018 at 11:12:00AM -0500, Eric Blake wrote:
>
> Why can't we fix Makefile to include BOTH the build and the source
> directories (to pick up generated files first, and then version-controlled
> files), and possibly include logic to simplify to a single -I instead of two
> when doing in-tree builds?
That's the issue. Whatever you do, #include "" pulls in the current
directory first.
--
MST
next prev parent reply other threads:[~2018-03-20 16:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 1:54 [PATCH] qemu: include generated files with <> and not "" Michael S. Tsirkin
2018-03-20 8:58 ` Laurent Vivier
2018-03-20 9:44 ` Daniel P. Berrangé
2018-03-20 10:01 ` Peter Maydell
2018-03-20 10:27 ` Daniel P. Berrangé
2018-03-20 11:52 ` Michael S. Tsirkin
2018-03-20 12:12 ` Michael S. Tsirkin
2018-03-20 12:18 ` Daniel P. Berrangé
2018-03-20 12:28 ` Michael S. Tsirkin
2018-03-20 12:39 ` Daniel P. Berrangé
2018-03-20 12:44 ` Michael S. Tsirkin
2018-03-20 13:32 ` Gerd Hoffmann
2018-03-20 13:41 ` Daniel P. Berrangé
2018-03-20 13:50 ` Michael S. Tsirkin
2018-03-20 13:58 ` Daniel P. Berrangé
2018-03-20 14:02 ` Michael S. Tsirkin
2018-03-20 13:54 ` Max Reitz
2018-03-20 17:12 ` Michael S. Tsirkin
2018-03-20 13:46 ` Thomas Huth
2018-03-20 13:53 ` Michael S. Tsirkin
2018-03-20 12:05 ` Michael S. Tsirkin
2018-03-21 7:16 ` [Qemu-ppc] " Thomas Huth
2018-03-21 13:08 ` Michael S. Tsirkin
2018-03-21 13:15 ` Stefan Weil
2018-03-21 13:24 ` Michael S. Tsirkin
2018-03-21 13:29 ` Daniel P. Berrangé
2018-03-21 13:42 ` Michael S. Tsirkin
2018-03-20 13:05 ` Michael S. Tsirkin
2018-03-20 13:10 ` [Qemu-block] " Stefan Hajnoczi
2018-03-20 13:30 ` Michael S. Tsirkin
2018-03-20 16:12 ` Eric Blake
2018-03-20 16:40 ` Daniel P. Berrangé
2018-03-20 16:51 ` Michael S. Tsirkin [this message]
2018-03-20 16:33 ` [Qemu-devel] " Stefan Weil
2018-03-20 17:10 ` Michael S. Tsirkin
2018-03-20 17:34 ` Daniel P. Berrangé
2018-03-20 17:49 ` Michael S. Tsirkin
2018-03-20 17:36 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320185013-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=ben@skyportsyst \
--cc=david@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiri@resnulli.us \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=lizhijian@cn.fujitsu.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=sheepdog@lists.wpkg.org \
--cc=sstabellini@kernel.org \
--cc=sundeep.lkml@gmail.com \
--cc=yongbok.kim@mips.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox