RE: [PATCH v5 0/7] vfio/type1: Add support for valid iova list management

Shameerali Kolothum Thodi
2018-03-19T10:54:40Z

Hi Kevin,

Thanks for taking a look at this series.

> -----Original Message-----
> From: Tian, Kevin [mailto:kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org]
> Sent: Monday, March 19, 2018 8:29 AM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>;
> alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org;
> pmorel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
> Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; xuwei (O)
> <xuwei5-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>; Linuxarm <linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>;
> iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> Subject: RE: [PATCH v5 0/7] vfio/type1: Add support for valid iova list
> management
>
> > From: Shameer Kolothum
> > Sent: Friday, March 16, 2018 12:35 AM
> >
> > This series introduces an iova list associated with a vfio
> > iommu. The list is kept updated taking care of iommu apertures,
> > and reserved regions. Also this series adds checks for any conflict
> > with existing dma mappings whenever a new device group is attached to
> > the domain.
> >
> > User-space can retrieve valid iova ranges using VFIO_IOMMU_GET_INFO
> > ioctl capability chains. Any dma map request outside the valid iova
> > range will be rejected.
>
> GET_INFO is done at initialization time which is good for cold attached
> devices. If a hotplugged device may cause change of valid iova ranges
> at run-time, then there could be potential problem (which however is
> difficult for user space or orchestration stack to figure out in advance)
> Can we do some extension like below to make hotplug case cleaner?

As I understand, in case a hotplugged device results in an update to the valid
Iova ranges then the Qemu, vfio_connect_container() --> memory_listner_register()
will fail if there is a conflict as patch #4 checks for invalid dma map requests.

Not sure, your concern is preventing hotplug much before this happens or not.

Thanks,
Shameer

> - An interface allowing user space to request VFIO rejecting further
> attach_group if doing so may cause iova range change. e.g. Qemu can
> do such request once completing initial GET_INFO;
>
> - or an event notification to user space upon change of valid iova
> ranges when attaching a new device at run-time. It goes one step
> further - even attach may cause iova range change, it may still
> succeed as long as Qemu hasn't allocated any iova in impacted
> range
>
> Thanks
> Kevin
>
> >
> >
> > v4 --> v5
> > Rebased to next-20180315.
> >
> > -Incorporated the corner case bug fix suggested by Alex to patch #5.
> > -Based on suggestions by Alex and Robin, added patch#7. This
> > moves the PCI window reservation back in to DMA specific path.
> > This is to fix the issue reported by Eric[1].
> >
> > Note:
> > The patch #7 has dependency with [2][3]
> >
> > 1. https://patchwork.kernel.org/patch/10232043/
> > 2. https://patchwork.kernel.org/patch/10216553/
> > 3. https://patchwork.kernel.org/patch/10216555/
> >
> > v3 --> v4
> > Addressed comments received for v3.
> > -dma_addr_t instead of phys_addr_t
> > -LIST_HEAD() usage.
> > -Free up iova_copy list in case of error.
> > -updated logic in filling the iova caps info(patch #5)
> >
> > RFCv2 --> v3
> > Removed RFC tag.
> > Addressed comments from Alex and Eric:
> > - Added comments to make iova list management logic more clear.
> > - Use of iova list copy so that original is not altered in
> > case of failure.
> >
> > RFCv1 --> RFCv2
> > Addressed comments from Alex:
> > -Introduced IOVA list management and added checks for conflicts with
> > existing dma map entries during attach/detach.
> >
> > Shameer Kolothum (2):
> > vfio/type1: Add IOVA range capability support
> > iommu/dma: Move PCI window region reservation back into dma specific
> > path.
> >
> > Shameerali Kolothum Thodi (5):
> > vfio/type1: Introduce iova list and add iommu aperture validity check
> > vfio/type1: Check reserve region conflict and update iova list
> > vfio/type1: Update iova list on detach
> > vfio/type1: check dma map request is within a valid iova range
> > vfio/type1: remove duplicate retrieval of reserved regions
> >
> > drivers/iommu/dma-iommu.c | 54 ++---
> > drivers/vfio/vfio_iommu_type1.c | 497
> > +++++++++++++++++++++++++++++++++++++++-
> > include/uapi/linux/vfio.h | 23 ++
> > 3 files changed, 533 insertions(+), 41 deletions(-)
> >
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > iommu mailing list
> > iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> > https://lists.linuxfoundation.org/mailman/listinfo/iommu