From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
"David Hildenbrand" <david@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-devel@nongnu.org, "BALATON Zoltan" <balaton@eik.bme.hu>,
"Keith Busch" <keith.busch@intel.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Hannes Reinecke" <hare@suse.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Fam Zheng" <famz@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
"Ben Warren" <ben@skyportsystems.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Richard W.M. Jones" <rjones@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>
Subject: Re: [PATCH v2] qemu: replace "" with <> in headers
Date: Wed, 21 Mar 2018 17:11:12 +0200 [thread overview]
Message-ID: <20180321170823-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3a819d04-b1d2-550e-7458-4ea7509db36d@redhat.com>
On Wed, Mar 21, 2018 at 04:04:29PM +0100, Paolo Bonzini wrote:
> On 21/03/2018 15:46, Michael S. Tsirkin wrote:
> > +if (m@^\s*#include\s+"qemu/@o) {
> > + s@^(\s*#include\s+)"qemu/([^"]+)"(.*)$@$1<qemu/common/$2>$3@o) {
> > +} else {
> > + s@^(\s*#include\s+)"([^"]+)"(.*)$@$1<qemu/$2>$3@o) {
> > +}
>
> Can you explain the changes in the source tree layout?
include/qemu -> include/qemu/common
include/* -> include/qemu/*
Thus one uses any qemu headers with
#include <qemu/....>
we can do the conversion gradually and avoid a flag day
with some use of softlinks.
> Also, s{}{} and m{} are a bit more readable.
>
> Paolo
Thanks, will use.
--
MST
next prev parent reply other threads:[~2018-03-21 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 14:46 [PATCH v2] qemu: replace "" with <> in headers Michael S. Tsirkin
2018-03-21 15:04 ` Paolo Bonzini
2018-03-21 15:11 ` Michael S. Tsirkin [this message]
2018-03-21 15:23 ` Paolo Bonzini
2018-03-21 15:19 ` Daniel P. Berrangé
2018-03-21 15:39 ` Michael S. Tsirkin
2018-03-21 15:54 ` Daniel P. Berrangé
2018-03-21 15:34 ` Kevin Wolf
2018-03-21 15:58 ` Michael S. Tsirkin
2018-03-21 16:22 ` Kevin Wolf
2018-03-22 19:29 ` Michael S. Tsirkin
2018-03-22 20:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321170823-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=ben@skyportsystems.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=famz@redhat.com \
--cc=hare@suse.com \
--cc=jcmvbkbc@gmail.com \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=yongbok.kim@mips.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox