From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH 4/8] migration: introduce control_save_page() Date: Tue, 27 Mar 2018 15:47:08 +0800 Message-ID: <20180327074708.GL17789@xz-mi> References: <20180313075739.11194-1-xiaoguangrong@tencent.com> <20180313075739.11194-5-xiaoguangrong@tencent.com> <20180315113759.GD3062@work-vm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, Xiao Guangrong , qemu-devel@nongnu.org, quintela@redhat.com, guangrong.xiao@gmail.com, pbonzini@redhat.com To: "Dr. David Alan Gilbert" Return-path: Content-Disposition: inline In-Reply-To: <20180315113759.GD3062@work-vm> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On Thu, Mar 15, 2018 at 11:37:59AM +0000, Dr. David Alan Gilbert wrote: > * guangrong.xiao@gmail.com (guangrong.xiao@gmail.com) wrote: > > From: Xiao Guangrong > > > > Abstract the common function control_save_page() to cleanup the code, > > no logic is changed > > > > Signed-off-by: Xiao Guangrong > > Reviewed-by: Dr. David Alan Gilbert > > It would be good to find a better name for control_save_page, but I > can't think of one!). Yeah. I would prefer it's at least still prefixed with ram_*, however I don't really hope we spend too much time on namings (always :). Maybe we can just squash the changes into current ram_control_save_page() directly. But that's optional, current patch is good to me already, so: Reviewed-by: Peter Xu -- Peter Xu