From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KarimAllah Ahmed <karahmed@amazon.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, hpa@zytor.com, jmattson@google.com,
mingo@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page
Date: Thu, 12 Apr 2018 10:57:42 -0700 [thread overview]
Message-ID: <20180412175742.GA14534@linux.intel.com> (raw)
In-Reply-To: <bdb99bea-9e5e-951e-3016-4acd162c619e@redhat.com>
On Thu, Apr 12, 2018 at 04:38:39PM +0200, Paolo Bonzini wrote:
> On 21/02/2018 18:47, KarimAllah Ahmed wrote:
> > +
> > + if (kvm_vcpu_map(vcpu, gpa_to_gfn(vmcs12->virtual_apic_page_addr), map))
> > + vmcs_write64(VIRTUAL_APIC_PAGE_ADDR, gfn_to_gpa(map->pfn));
>
> This should in principle be pfn_to_hpa. However, pfn_to_hpa is unused;
> let's just remove it and do "<< PAGE_SHIFT". Unlike gfn_to_gpa, where
> in principle the shift could be different, pfn_to_hpa is *by definition*
> a shift left by PAGE_SHIFT.
Any reason not to use PFN_PHYS instead of the handcoded shift?
> Paolo
next prev parent reply other threads:[~2018-04-12 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1519235241-6500-1-git-send-email-karahmed@amazon.de>
2018-03-01 15:24 ` [PATCH 00/10] KVM/X86: Handle guest memory that does not have a struct page Raslan, KarimAllah
2018-03-01 17:51 ` Jim Mattson
2018-03-02 17:40 ` Paolo Bonzini
[not found] ` <1519235241-6500-5-git-send-email-karahmed@amazon.de>
2018-04-12 14:33 ` [PATCH 04/10] KVM: Introduce a new guest mapping API Paolo Bonzini
[not found] ` <1519235241-6500-6-git-send-email-karahmed@amazon.de>
2018-04-12 14:36 ` [PATCH 05/10] KVM/nVMX: Use kvm_vcpu_map when mapping the L1 MSR bitmap Paolo Bonzini
[not found] ` <1519235241-6500-7-git-send-email-karahmed@amazon.de>
2018-04-12 14:38 ` [PATCH 06/10] KVM/nVMX: Use kvm_vcpu_map when mapping the virtual APIC page Paolo Bonzini
2018-04-12 17:57 ` Sean Christopherson [this message]
2018-04-12 20:23 ` Paolo Bonzini
[not found] ` <1519235241-6500-8-git-send-email-karahmed@amazon.de>
2018-04-12 14:39 ` [PATCH 07/10] KVM/nVMX: Use kvm_vcpu_map when mapping the posted interrupt descriptor table Paolo Bonzini
2018-04-12 14:59 ` [PATCH 00/10] KVM/X86: Handle guest memory that does not have a struct page Paolo Bonzini
2018-04-12 21:25 ` Raslan, KarimAllah
[not found] ` <1519235241-6500-4-git-send-email-karahmed@amazon.de>
2018-04-12 15:03 ` [PATCH 03/10] X86/nVMX: Update the PML table without mapping and unmapping the page Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412175742.GA14534@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox