From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Wanpeng Li" <kernellwp@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH 0/4] move kvm_para.h to standard-headers
Date: Tue, 15 May 2018 15:33:54 +0300 [thread overview]
Message-ID: <20180515061211-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1523991487-241006-1-git-send-email-mst@redhat.com>
On Tue, Apr 17, 2018 at 09:58:16PM +0300, Michael S. Tsirkin wrote:
> kvm_para.h is normally an interface for guest. It's natural to need the
> header in host to emulate that in qemu.
>
> ATM it does not actually work on non-kvm systems, which allowed us to
> get by sticking it in linux-headers and only pulling it in on Linux, but
> that turns out to be more pain than it's worth.
>
> The result seems to be that we are forced to duplicate
> more and more code from there when we are in portable code.
> Not nice.
>
> Let's just pull it into standard-headers instead, and use
> on all platforms unconditionally.
>
> It turns out we only need the x86 version, so that is
> and extra a plus - drop the rest.
Ping kvm maintainers - any comments?
Should I merge this one?
> Michael S. Tsirkin (4):
> update-linux-headers.sh: drop kvm_para.h hacks
> include/standard-headers: add asm-x86/kvm_para.h
> x86/cpu: use standard-headers/asm-x86.kvm_para.h
> linux-headers: drop kvm_para.h
>
> .../standard-headers}/asm-x86/kvm_para.h | 49 ++++++-----
> include/sysemu/kvm.h | 1 -
> linux-headers/asm-arm/kvm_para.h | 2 -
> linux-headers/asm-arm64/kvm_para.h | 1 -
> linux-headers/asm-generic/kvm_para.h | 4 -
> linux-headers/asm-mips/kvm_para.h | 5 --
> linux-headers/asm-powerpc/epapr_hcalls.h | 99 ----------------------
> linux-headers/asm-powerpc/kvm_para.h | 98 ---------------------
> linux-headers/asm-s390/kvm_para.h | 8 --
> linux-headers/linux/kvm_para.h | 35 --------
> target/i386/cpu.h | 2 -
> target/i386/kvm_i386.h | 6 --
> hw/i386/kvm/clock.c | 2 +-
> target/i386/cpu.c | 4 +-
> target/i386/kvm.c | 4 +-
> scripts/update-linux-headers.sh | 16 ++--
> 16 files changed, 35 insertions(+), 301 deletions(-)
> rename {linux-headers => include/standard-headers}/asm-x86/kvm_para.h (80%)
> delete mode 100644 linux-headers/asm-arm/kvm_para.h
> delete mode 100644 linux-headers/asm-arm64/kvm_para.h
> delete mode 100644 linux-headers/asm-generic/kvm_para.h
> delete mode 100644 linux-headers/asm-mips/kvm_para.h
> delete mode 100644 linux-headers/asm-powerpc/epapr_hcalls.h
> delete mode 100644 linux-headers/asm-powerpc/kvm_para.h
> delete mode 100644 linux-headers/asm-s390/kvm_para.h
> delete mode 100644 linux-headers/linux/kvm_para.h
>
> --
> MST
>
next prev parent reply other threads:[~2018-05-15 12:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 18:58 [PATCH 0/4] move kvm_para.h to standard-headers Michael S. Tsirkin
2018-04-17 18:58 ` [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks Michael S. Tsirkin
2018-04-17 21:12 ` Eduardo Habkost
2018-04-18 7:54 ` Cornelia Huck
2018-04-18 16:05 ` Michael S. Tsirkin
2018-04-18 17:41 ` Cornelia Huck
2018-04-18 17:42 ` Cornelia Huck
2018-04-17 18:58 ` [PATCH 3/4] x86/cpu: use standard-headers/asm-x86.kvm_para.h Michael S. Tsirkin
2018-04-17 20:05 ` Eduardo Habkost
2018-04-17 18:58 ` [PATCH 2/4] include/standard-headers: add asm-x86/kvm_para.h Michael S. Tsirkin
2018-04-17 21:12 ` Eduardo Habkost
2018-04-17 18:58 ` [PATCH 4/4] linux-headers: drop kvm_para.h Michael S. Tsirkin
2018-04-17 22:05 ` Eduardo Habkost
2018-04-17 19:05 ` [PATCH 0/4] move kvm_para.h to standard-headers no-reply
2018-05-15 12:33 ` Michael S. Tsirkin [this message]
2018-05-15 12:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515061211-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox