From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: x86: VMX: fix building without CONFIG_HYPERV Date: Sat, 26 May 2018 16:18:11 +0200 Message-ID: <20180526141810.GA23390@flask> References: <20180525153640.3228067-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paolo Bonzini , Lan Tianyu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jim Mattson , Wanpeng Li , David Hildenbrand , Vitaly Kuznetsov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Arnd Bergmann Return-path: Content-Disposition: inline In-Reply-To: <20180525153640.3228067-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2018-05-25 17:36+0200, Arnd Bergmann: > The global ms_hyperv variable is part of the hyperv support, so > we get a link error from accessing it in kernels that have this > turned off: > > arch/x86/kvm/vmx.o: In function `alloc_loaded_vmcs': > vmx.c:(.text+0x1654a): undefined reference to `ms_hyperv' > vmx.c:(.text+0x1657a): undefined reference to `ms_hyperv' > > This changes the condition to first check the compile-time > configuration symbol to avoid the link error. > > Fixes: ceef7d10dfb6 ("KVM: x86: VMX: hyper-v: Enlightened MSR-Bitmap support") > Signed-off-by: Arnd Bergmann Queued, thanks.