public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Wanpeng Li" <kernellwp@gmail.com>,
	"Thomas-Mich Richter" <tmricht@linux.ibm.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"KVM list" <kvm@vger.kernel.org>
Subject: Re: [GIT PULL] KVM changes for 4.18 merge window
Date: Wed, 13 Jun 2018 06:48:40 +0200	[thread overview]
Message-ID: <20180613044840.GA669@kroah.com> (raw)
In-Reply-To: <CA+55aFw3a1j1GCTtf2C2bDML13G9aZ=bT2ysmXY7=fnHJups2w@mail.gmail.com>

On Tue, Jun 12, 2018 at 08:52:08PM -0700, Linus Torvalds wrote:
> On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses
> > mode permission from parent") breaks lkvm, and I think qemu-kvm too.
> >
> > The commit looks like the RightThing(tm) to do, but we do not break
> > existing work-flows, no matter how much we'd like to.  So it gets
> > reverted.
> 
> I suspect it's the special kvm debugfs entries - see kvm_create_vm_debugfs()
> 
> Anyway, I've verified that both qemu-kvm and kvm-tool work fine with
> the revert in place.

I should have read the whole thread :)

The revert is fine, I'll work on the kvm debugfs file stuff for 4.19.

thanks,

greg k-h

  reply	other threads:[~2018-06-13  4:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 14:03 [GIT PULL] KVM changes for 4.18 merge window Paolo Bonzini
2018-06-12 18:43 ` Linus Torvalds
2018-06-13 13:41   ` Dave Martin
2018-06-13  2:18 ` Linus Torvalds
2018-06-13  2:41   ` Linus Torvalds
2018-06-13  2:50     ` Wanpeng Li
2018-06-13  3:00       ` Linus Torvalds
2018-06-13  3:26         ` Linus Torvalds
2018-06-13  3:52           ` Linus Torvalds
2018-06-13  4:48             ` Greg Kroah-Hartman [this message]
2018-06-13  4:52               ` Linus Torvalds
2018-06-13 10:03                 ` Wanpeng Li
2018-06-13  4:47           ` Greg Kroah-Hartman
2018-06-13 10:09   ` Paolo Bonzini
2018-06-13 10:59     ` Vitaly Kuznetsov
2018-06-13 14:00       ` Linus Torvalds
2018-06-13 13:56     ` Linus Torvalds
2018-06-13 14:26       ` Paolo Bonzini
2018-06-13 14:29         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613044840.GA669@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tmricht@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox