From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies
Date: Tue, 19 Jun 2018 23:44:59 +0200
Message-ID: <20180619214459.GI31750@zn.tnic>
References: <1526915573-22917-1-git-send-email-Janakarajan.Natarajan@amd.com>
 <20180523144621.GB25143@pd.tnic>
 <CAFLxGvyxHU_Xahwdf=0TYx8Nems78TLioLZGGLTkxNGCgxT4Dg@mail.gmail.com>
 <4f565a11-9e99-b861-06d2-b42922e44c7a@amd.com>
 <20180619094658.GB31750@zn.tnic>
 <3953c12f-c2fe-5d1d-bee2-ac9a230300b8@amd.com>
 <20180619194350.GG31750@zn.tnic>
 <15f10b01-e32f-5fc1-a2e6-3c6ab1461b30@amd.com>
 <20180619213255.GH31750@zn.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
        Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>, x86@kernel.org,
        kvm <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim Krcmar <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, felix@feldspaten.org
To: Brijesh Singh <brijesh.singh@amd.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20180619213255.GH31750@zn.tnic>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, Jun 19, 2018 at 11:32:56PM +0200, Borislav Petkov wrote:
> config CRYPTO_DEV_SP_PSP
>         bool "Platform Security Processor (PSP) device"
>         default y
>         depends on CRYPTO_DEV_CCP_DD && X86_64
> 
> so CRYPTO_DEV_SP_PSP already depends on CRYPTO_DEV_CCP_DD!
> 
> So why should KVM_AMD_SEV depend on CRYPTO_DEV_CCP_DD too?!? Do you
> catch my drift?

And then in addition to that, KVM_AMD_SEV needs to "synchronize"
selection states so that KVM_AMD *and* CRYPTO_DEV_SP_PSP both have the
same setting - either =m or =y - so that the build works.

I can't think of a proper way to fix that right now, though, need to
sleep on it.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--