From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v4 1/2] kvm: support -overcommit
 cpu-pm=on|off
Date: Fri, 22 Jun 2018 15:34:48 -0300
Message-ID: <20180622183448.GB7451@localhost.localdomain>
References: <20180622003140.164613-1-mst@redhat.com>
	<20180622003140.164613-2-mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Richard Henderson <rth@twiddle.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <20180622003140.164613-2-mst@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org>
List-Id: kvm.vger.kernel.org

On Fri, Jun 22, 2018 at 03:31:48AM +0300, Michael S. Tsirkin wrote:
[...]
> -                enable_mlock = qemu_opt_get_bool(opts, "mlock", true);
> +                /* Don't override the -dedicated option if set */
> +                enable_mlock = enable_mlock ||
> +                    qemu_opt_get_bool(opts, "mlock", true);
> +                break;
> +            case QEMU_OPTION_dedicated:
> +                opts = qemu_opts_parse_noisily(qemu_find_opts("dedicated"),
> +                                               optarg, false);
> +                if (!opts) {
> +                    exit(1);
> +                }
> +                /* Don't override the -realtime option if set */
> +                enable_mlock = enable_mlock ||
> +                    qemu_opt_get_bool(opts, "mem-lock", false);
> +                enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", false);

I would prefer to simply make the last option win, because it
would be more obvious.  But not a big deal if we are going to
deprecate -realtime.

BTW, are you going to send a qemu-doc.texi patch documenting
-realtime as deprecated?

-- 
Eduardo