From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] sample/vfio-mdev: Change return type to vm_fault_t Date: Thu, 5 Jul 2018 13:44:32 -0600 Message-ID: <20180705134432.17609cc7@t450s.home> References: <20180704153014.GA26121@jordon-HP-15-Notebook-PC> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: willy@infradead.org, kwankhede@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, svptas.linux@gmail.com, brajeswar.linux@gmail.com, sabyasachi.linux@gmail.com, ajitn.linux@gmail.com To: Souptick Joarder Return-path: In-Reply-To: <20180704153014.GA26121@jordon-HP-15-Notebook-PC> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 4 Jul 2018 21:00:14 +0530 Souptick Joarder wrote: > convert mbochs_region_vm_fault and mbochs_dmabuf_vm_fault > to return vm_fault_t type. > > Signed-off-by: Souptick Joarder > --- > samples/vfio-mdev/mbochs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c > index 2960e26..7743fbc 100644 > --- a/samples/vfio-mdev/mbochs.c > +++ b/samples/vfio-mdev/mbochs.c > @@ -657,7 +657,7 @@ static void mbochs_put_pages(struct mdev_state *mdev_state) > dev_dbg(dev, "%s: %d pages released\n", __func__, count); > } > > -static int mbochs_region_vm_fault(struct vm_fault *vmf) > +static vm_fault_t mbochs_region_vm_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > struct mdev_state *mdev_state = vma->vm_private_data; > @@ -695,7 +695,7 @@ static int mbochs_mmap(struct mdev_device *mdev, struct vm_area_struct *vma) > return 0; > } > > -static int mbochs_dmabuf_vm_fault(struct vm_fault *vmf) > +static vm_fault_t mbochs_dmabuf_vm_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > struct mbochs_dmabuf *dmabuf = vma->vm_private_data; Looks good to me, I'll include this in my vfio for-linus branch for v4.18. Thanks, Alex