From: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"vkuznets@redhat.com" <vkuznets@redhat.com>
Subject: [PATCH V2 4/5] KVM/x86: Add tlb_remote_flush callback support for vmx
Date: Mon, 9 Jul 2018 09:02:54 +0000 [thread overview]
Message-ID: <20180709090218.15342-5-Tianyu.Lan@microsoft.com> (raw)
In-Reply-To: <20180709090218.15342-1-Tianyu.Lan@microsoft.com>
Register tlb_remote_flush callback for vmx when hyperv capability of
nested guest mapping flush is detected. The interface can help to
reduce overhead when flush ept table among vcpus for nested VM. The
tradition way is to send IPIs to all affected vcpus and executes
INVEPT on each vcpus. It will trigger several vmexits for IPI
and INVEPT emulation. Hyper-V provides such hypercall to do
flush for all vcpus.
Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
---
Change since v1:
Use ept_pointers_match to check condition of identical ept
table pointer and get ept pointer from struct vcpu_vmx->ept_pointer.
---
arch/x86/kvm/vmx.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 8142b2da430a..55fe14d1d4d4 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4778,6 +4778,25 @@ static inline void __vmx_flush_tlb(struct kvm_vcpu *vcpu, int vpid,
}
}
+static int hv_remote_flush_tlb(struct kvm *kvm)
+{
+ int ret;
+
+ spin_lock(&to_kvm_vmx(kvm)->ept_pointer_lock);
+
+ if (!to_kvm_vmx(kvm)->ept_pointers_match) {
+ ret = -EFAULT;
+ goto out;
+ }
+
+ ret = hyperv_flush_guest_mapping(
+ to_vmx(kvm_get_vcpu(kvm, 0))->ept_pointer);
+
+out:
+ spin_unlock(&to_kvm_vmx(kvm)->ept_pointer_lock);
+ return ret;
+}
+
static void vmx_flush_tlb(struct kvm_vcpu *vcpu, bool invalidate_gpa)
{
__vmx_flush_tlb(vcpu, to_vmx(vcpu)->vpid, invalidate_gpa);
@@ -4968,7 +4987,7 @@ static void check_ept_pointer(struct kvm_vcpu *vcpu, u64 eptp)
u64 tmp_eptp = INVALID_PAGE;
int i;
- if (!kvm_x86_ops->tlb_remote_flush)
+ if (!kvm_x86_ops->hv_tlb_remote_flush)
return;
spin_lock(&to_kvm_vmx(kvm)->ept_pointer_lock);
@@ -7570,6 +7589,12 @@ static __init int hardware_setup(void)
if (enable_ept && !cpu_has_vmx_ept_2m_page())
kvm_disable_largepages();
+#if IS_ENABLED(CONFIG_HYPERV)
+ if (ms_hyperv.nested_features & HV_X64_NESTED_GUEST_MAPPING_FLUSH
+ && enable_ept)
+ kvm_x86_ops->hv_tlb_remote_flush = hv_remote_flush_tlb;
+#endif
+
if (!cpu_has_vmx_ple()) {
ple_gap = 0;
ple_window = 0;
--
2.14.3
prev parent reply other threads:[~2018-07-09 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 9:02 [PATCH V2 0/5] KVM/x86/hyper-V: Introduce PV guest address space mapping flush support Tianyu Lan
2018-07-09 9:02 ` [PATCH V2 1/5] X86/Hyper-V: Add flush HvFlushGuestPhysicalAddressSpace hypercall support Tianyu Lan
2018-07-10 21:29 ` Michael Kelley (EOSG)
2018-07-11 6:01 ` Tianyu Lan
2018-07-09 9:02 ` [PATCH V2 2/5] KVM: Add tlb remote flush callback in kvm_x86_ops Tianyu Lan
2018-07-18 11:57 ` Paolo Bonzini
2018-07-18 12:01 ` Paolo Bonzini
2018-07-18 13:25 ` Tianyu Lan
2018-07-09 9:02 ` [PATCH V2 3/5] KVM/VMX: Add identical ept table pointer check Tianyu Lan
2018-07-18 11:59 ` Paolo Bonzini
2018-07-18 13:38 ` Tianyu Lan
2018-07-09 9:02 ` Tianyu Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709090218.15342-5-Tianyu.Lan@microsoft.com \
--to=tianyu.lan@microsoft.com \
--cc=Michael.H.Kelley@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox