kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Peter Zijlstra <peterz@infradead.org>,
	mhillenb@amazon.de, linux-kernel <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>
Subject: Re: [RFC] Make need_resched() return true when rcu_urgent_qs requested
Date: Wed, 18 Jul 2018 20:11:52 -0700	[thread overview]
Message-ID: <20180719031152.GR12945@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180719003205.GB5595@lerouge>

On Thu, Jul 19, 2018 at 02:32:06AM +0200, Frederic Weisbecker wrote:
> On Wed, Jul 11, 2018 at 06:03:42PM +0100, David Woodhouse wrote:
> > On Wed, 2018-07-11 at 09:49 -0700, Paul E. McKenney wrote:
> > > And here is an updated v4.15 patch with Marius's Reported-by and David's
> > > fix to my lost exclamation point.
> > 
> > Thanks. Are you sending the original version of that to Linus? It'd be
> > useful to have the commit ID so that we can watch for it landing, and
> > chase this one up to Greg.
> > 
> > As discussed on IRC, this patch reduces synchronize_sched() latency for
> > us from ~4600s to ~160ms, which is nice.
> > 
> > However, it isn't going to be sufficient in the NO_HZ_FULL case. For
> > that you want a patch like the one below, which happily reduces the
> > latency in our (!NO_HZ_FULL) case still further to ~40ms.
> 
> That is interesting. As I replied to Paul, we are already calling
> rcu_user_enter/exit() on guest_enter/exit_irqsoff(). So I'm wondering why
> you're seeing such an optimization by repeating those calls.
> 
> Perhaps the rcu_user_* somehow aren't actually called from
> __context_tracking_enter()...? Some bug in context tracking?
> Otherwise it's a curious side effect.

David is working with v4.15.  Is this maybe something that has changed
since then?

							Thanx, Paul

  reply	other threads:[~2018-07-19  3:11 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180709163432.GV3593@linux.vnet.ibm.com>
     [not found] ` <1531162254.26547.3.camel@infradead.org>
     [not found]   ` <20180709203441.GE3593@linux.vnet.ibm.com>
     [not found]     ` <1531168538.26547.5.camel@infradead.org>
     [not found]       ` <20180709204248.GF3593@linux.vnet.ibm.com>
     [not found]         ` <1531169145.26547.8.camel@infradead.org>
     [not found]           ` <20180709210532.GH3593@linux.vnet.ibm.com>
     [not found]             ` <20180709220823.GA18045@linux.vnet.ibm.com>
     [not found]               ` <1531319025.8759.57.camel@infradead.org>
     [not found]                 ` <20180711144303.GQ3593@linux.vnet.ibm.com>
     [not found]                   ` <20180711164952.GA29994@linux.vnet.ibm.com>
2018-07-11 17:03                     ` [RFC] Make need_resched() return true when rcu_urgent_qs requested David Woodhouse
2018-07-11 17:48                       ` Paul E. McKenney
2018-07-11 18:01                         ` [PATCH v2] kvm/x86: Inform RCU of quiescent state when entering guest mode David Woodhouse
2018-07-11 18:20                           ` Paul E. McKenney
2018-07-11 18:36                             ` Paul E. McKenney
2018-07-11 18:39                               ` Christian Borntraeger
2018-07-11 20:27                                 ` Paul E. McKenney
2018-07-11 20:54                                   ` David Woodhouse
2018-07-11 21:09                                     ` Paul E. McKenney
2018-07-11 21:11                                   ` Christian Borntraeger
2018-07-11 21:32                                     ` Paul E. McKenney
2018-07-11 21:39                                       ` Christian Borntraeger
2018-07-11 23:47                                         ` Paul E. McKenney
2018-07-12  8:31                                           ` David Woodhouse
2018-07-12 11:00                                             ` Christian Borntraeger
2018-07-12 11:10                                               ` David Woodhouse
2018-07-12 11:58                                                 ` Christian Borntraeger
2018-07-12 12:04                                                   ` Christian Borntraeger
2018-07-11 23:37                                       ` Paul E. McKenney
2018-07-12  2:15                                         ` Paul E. McKenney
2018-07-12  6:21                                         ` Christian Borntraeger
2018-07-12  9:52                                           ` David Woodhouse
2018-07-11 18:31                       ` [RFC] Make need_resched() return true when rcu_urgent_qs requested Christian Borntraeger
2018-07-11 20:17                         ` Paul E. McKenney
2018-07-11 20:19                           ` David Woodhouse
2018-07-11 21:08                             ` Paul E. McKenney
2018-07-12 12:00                               ` David Woodhouse
2018-07-12 12:53                                 ` Paul E. McKenney
2018-07-12 16:17                                   ` Paul E. McKenney
2018-07-16 15:40                                     ` Paul E. McKenney
2018-07-17  8:19                                       ` David Woodhouse
2018-07-17 12:56                                         ` Paul E. McKenney
2018-07-18 15:36                                           ` Paul E. McKenney
2018-07-18 16:01                                             ` David Woodhouse
2018-07-18 16:37                                               ` Paul E. McKenney
2018-07-18 19:41                                                 ` David Woodhouse
2018-07-18 20:17                                                   ` Paul E. McKenney
2018-07-19  0:26                                                     ` Frederic Weisbecker
2018-07-19  6:45                                                     ` Christian Borntraeger
2018-07-19  7:20                                                       ` David Woodhouse
2018-07-19 10:23                                                         ` Christian Borntraeger
2018-07-19 12:55                                                           ` Paul E. McKenney
2018-07-19 13:14                                                         ` Frederic Weisbecker
2018-07-19 13:36                                                           ` David Woodhouse
2018-07-19 17:09                                                 ` Paul E. McKenney
2018-07-23  8:08                                                   ` David Woodhouse
2018-07-23 12:22                                                     ` Paul E. McKenney
2018-07-19  0:32                       ` Frederic Weisbecker
2018-07-19  3:11                         ` Paul E. McKenney [this message]
2018-07-19  6:16                           ` David Woodhouse
2018-07-19 13:17                             ` Frederic Weisbecker
2018-07-19 13:15                           ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719031152.GR12945@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=dwmw2@infradead.org \
    --cc=frederic@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhillenb@amazon.de \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).