From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v3 01/10] migration: do not wait for free
 thread
Date: Wed, 8 Aug 2018 11:51:27 +0800
Message-ID: <20180808035127.GD24415@xz-mi>
References: <20180807091209.13531-1-xiaoguangrong@tencent.com>
	<20180807091209.13531-2-xiaoguangrong@tencent.com>
	<6fb46b1e-5cae-24ec-acd6-72ba562a5c05@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com,
	Xiao Guangrong <xiaoguangrong@tencent.com>,
	qemu-devel@nongnu.org, dgilbert@redhat.com, wei.w.wang@intel.com,
	guangrong.xiao@gmail.com, jiang.biao2@zte.com.cn, pbonzini@redhat.com
To: Eric Blake <eblake@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <6fb46b1e-5cae-24ec-acd6-72ba562a5c05@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org>
List-Id: kvm.vger.kernel.org

On Tue, Aug 07, 2018 at 08:29:54AM -0500, Eric Blake wrote:
> On 08/07/2018 04:12 AM, guangrong.xiao@gmail.com wrote:
> > From: Xiao Guangrong <xiaoguangrong@tencent.com>
> > 
> > Instead of putting the main thread to sleep state to wait for
> > free compression thread, we can directly post it out as normal
> > page that reduces the latency and uses CPUs more efficiently
> > 
> > A parameter, compress-wait-thread, is introduced, it can be
> > enabled if the user really wants the old behavior
> > 
> > Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com>
> > ---
> 
> > +++ b/qapi/migration.json
> > @@ -462,6 +462,11 @@
> >   # @compress-threads: Set compression thread count to be used in live migration,
> >   #          the compression thread count is an integer between 1 and 255.
> >   #
> > +# @compress-wait-thread: Wait if no thread is free to compress the memory page
> > +#          if it's enabled, otherwise, the page will be posted out immediately
> > +#          in the main thread without compression. It's true on default.
> > +#          (Since: 3.1)
> 
> Grammar suggestion:
> 
> @compress-wait-thread: Controls behavior when all compression threads are
> currently busy. If true (default), wait for a free compression thread to
> become available; otherwise, send the page uncompressed. (Since 3.1)

Eric's version seems better.  With that:

Reviewed-by: Peter Xu <peterx@redhat.com>

Regards,

-- 
Peter Xu