public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* Re: Linux 4.18.1
       [not found] <20180816101429.GA10680@kroah.com>
@ 2018-08-16 13:05 ` Adam Borowski
  2018-08-16 13:59   ` Sven Joachim
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Borowski @ 2018-08-16 13:05 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-kernel, Andrew Morton, stable, x86, kvm, Paolo Bonzini,
	Jiri Kosina, Thomas Gleixner

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi!

On Thu, Aug 16, 2018 at 12:14:29PM +0200, Greg KH wrote:
> I'm announcing the release of the 4.18.1 kernel.

I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:

ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilities':
(.text+0x43b2): undefined reference to `l1tf_vmx_mitigation'

gcc 8.2.0-4, as shipped in Debian unstable.
.config attached.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ What Would Jesus Do, MUD/MMORPG edition:
⣾⠁⢰⠒⠀⣿⡁ • multiplay with an admin char to benefit your mortal [Mt3:16-17]
⢿⡄⠘⠷⠚⠋⠀ • abuse item cloning bugs [Mt14:17-20, Mt15:34-37]
⠈⠳⣄⠀⠀⠀⠀ • use glitches to walk on water [Mt14:25-26]

[-- Attachment #2: config.xz --]
[-- Type: application/x-xz, Size: 33444 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Linux 4.18.1
  2018-08-16 13:05 ` Linux 4.18.1 Adam Borowski
@ 2018-08-16 13:59   ` Sven Joachim
  2018-08-16 15:11     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Sven Joachim @ 2018-08-16 13:59 UTC (permalink / raw)
  To: Adam Borowski
  Cc: Greg KH, linux-kernel, Andrew Morton, stable, x86, kvm,
	Paolo Bonzini, Jiri Kosina, Thomas Gleixner

On 2018-08-16 15:05 +0200, Adam Borowski wrote:

> On Thu, Aug 16, 2018 at 12:14:29PM +0200, Greg KH wrote:
>> I'm announcing the release of the 4.18.1 kernel.
>
> I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:
>
> ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilities':
> (.text+0x43b2): undefined reference to `l1tf_vmx_mitigation'

Same here and also in 4.17.15, but not in Linus' tree.

> .config attached.

Probably relevant:

> CONFIG_KVM=y
> # CONFIG_KVM_INTEL is not set
> CONFIG_KVM_AMD=y

I have CONFIG_KVM{,AMD}=m and CONFIG_KVM_INTEL is not set either.

Cheers,
       Sven

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Linux 4.18.1
  2018-08-16 13:59   ` Sven Joachim
@ 2018-08-16 15:11     ` Greg KH
  2018-08-16 15:43       ` Adam Borowski
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2018-08-16 15:11 UTC (permalink / raw)
  To: Sven Joachim
  Cc: Adam Borowski, linux-kernel, Andrew Morton, stable, x86, kvm,
	Paolo Bonzini, Jiri Kosina, Thomas Gleixner

On Thu, Aug 16, 2018 at 03:59:58PM +0200, Sven Joachim wrote:
> On 2018-08-16 15:05 +0200, Adam Borowski wrote:
> 
> > On Thu, Aug 16, 2018 at 12:14:29PM +0200, Greg KH wrote:
> >> I'm announcing the release of the 4.18.1 kernel.
> >
> > I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:
> >
> > ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilities':
> > (.text+0x43b2): undefined reference to `l1tf_vmx_mitigation'
> 
> Same here and also in 4.17.15, but not in Linus' tree.
> 
> > .config attached.
> 
> Probably relevant:
> 
> > CONFIG_KVM=y
> > # CONFIG_KVM_INTEL is not set
> > CONFIG_KVM_AMD=y
> 
> I have CONFIG_KVM{,AMD}=m and CONFIG_KVM_INTEL is not set either.

This is fixed in my queue, if it really bothers you, apply commit
1eb46908b35d ("x86/l1tf: Fix build error seen if CONFIG_KVM_INTEL is
disabled") to your tree, it will be in the next round of stable kernel
releases.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Linux 4.18.1
  2018-08-16 15:11     ` Greg KH
@ 2018-08-16 15:43       ` Adam Borowski
  0 siblings, 0 replies; 4+ messages in thread
From: Adam Borowski @ 2018-08-16 15:43 UTC (permalink / raw)
  To: Greg KH
  Cc: Sven Joachim, linux-kernel, Andrew Morton, stable, x86, kvm,
	Paolo Bonzini, Jiri Kosina, Thomas Gleixner

On Thu, Aug 16, 2018 at 05:11:21PM +0200, Greg KH wrote:
> On Thu, Aug 16, 2018 at 03:59:58PM +0200, Sven Joachim wrote:
> > On 2018-08-16 15:05 +0200, Adam Borowski wrote:
> > > I'm afraid that I get a build failure; v4.18 is ok, v4.18.1 fails with:
> > >
> > > ld: arch/x86/kvm/x86.o: in function `kvm_get_arch_capabilities':
> > > (.text+0x43b2): undefined reference to `l1tf_vmx_mitigation'
> > 
> > Same here and also in 4.17.15, but not in Linus' tree.
> > 
> > > CONFIG_KVM=y
> > > # CONFIG_KVM_INTEL is not set
> > > CONFIG_KVM_AMD=y
> > 
> > I have CONFIG_KVM{,AMD}=m and CONFIG_KVM_INTEL is not set either.
> 
> This is fixed in my queue, if it really bothers you, apply commit
> 1eb46908b35d ("x86/l1tf: Fix build error seen if CONFIG_KVM_INTEL is
> disabled") to your tree, it will be in the next round of stable kernel
> releases.

Probably obvious, but: cherry-picking that commit fixes the problem, it
builds, boots and works ok.

Thanks!


Meow.
-- 
⢀⣴⠾⠻⢶⣦⠀ What Would Jesus Do, MUD/MMORPG edition:
⣾⠁⢰⠒⠀⣿⡁ • multiplay with an admin char to benefit your mortal [Mt3:16-17]
⢿⡄⠘⠷⠚⠋⠀ • abuse item cloning bugs [Mt14:17-20, Mt15:34-37]
⠈⠳⣄⠀⠀⠀⠀ • use glitches to walk on water [Mt14:25-26]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-16 15:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20180816101429.GA10680@kroah.com>
2018-08-16 13:05 ` Linux 4.18.1 Adam Borowski
2018-08-16 13:59   ` Sven Joachim
2018-08-16 15:11     ` Greg KH
2018-08-16 15:43       ` Adam Borowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox