From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v2 1/5] KVM: s390: vsie: BUG correction by shadow_crycb Date: Thu, 23 Aug 2018 09:27:22 +0200 Message-ID: <20180823092722.5853bd4b.cohuck@redhat.com> References: <1534956717-14087-1-git-send-email-pmorel@linux.ibm.com> <1534956717-14087-2-git-send-email-pmorel@linux.ibm.com> <8300634d-8500-1898-e283-175fc893054a@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Pierre Morel , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, borntraeger@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com To: David Hildenbrand Return-path: In-Reply-To: <8300634d-8500-1898-e283-175fc893054a@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 22 Aug 2018 18:53:02 +0200 David Hildenbrand wrote: > On 22.08.2018 18:51, Pierre Morel wrote: > > Copy the key mask to the right offset inside the shadow CRYCB > > > > Signed-off-by: Pierre Morel > > Reviewed-by: David Hildenbrand > > --- > > arch/s390/kvm/vsie.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c > > index 9175518..12b9707 100644 > > --- a/arch/s390/kvm/vsie.c > > +++ b/arch/s390/kvm/vsie.c > > @@ -173,7 +173,8 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) > > return set_validity_icpt(scb_s, 0x0039U); > > > > /* copy only the wrapping keys */ > > - if (read_guest_real(vcpu, crycb_addr + 72, &vsie_page->crycb, 56)) > > + if (read_guest_real(vcpu, crycb_addr + 72, > > + vsie_page->crycb.dea_wrapping_key_mask, 56)) > > return set_validity_icpt(scb_s, 0x0035U); > > > > scb_s->ecb3 |= ecb3_flags; > > > > Please fixup the subject as requested. +1 > (were there more RB-s?) > Yep, mine. FTR: Reviewed-by: Cornelia Huck