From: Christoffer Dall <christoffer.dall@arm.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Christoffer Dall <cdall@cs.columbia.edu>,
kvm@vger.kernel.org, marc.zyngier@arm.com,
ynorov@caviumnetworks.com, kvmarm@lists.cs.columbia.edu,
shihwei@cs.columbia.edu
Subject: Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench
Date: Mon, 3 Sep 2018 15:14:31 +0200 [thread overview]
Message-ID: <20180903131431.GL4029@e113682-lin.lund.arm.com> (raw)
In-Reply-To: <20180903121130.uhkkz2avwknhxobs@kamzik.brq.redhat.com>
On Mon, Sep 03, 2018 at 02:11:30PM +0200, Andrew Jones wrote:
> On Mon, Sep 03, 2018 at 01:12:36PM +0200, Christoffer Dall wrote:
> > On Thu, Aug 30, 2018 at 04:17:33PM +0200, Andrew Jones wrote:
> > > From: Shih-Wei Li <shihwei@cs.columbia.edu>
> > >
> > > Here we provide the support for measuring various micro level
> > > operations on arm64. Measurements are currently obtained using
> > > timer counters. Further modifications in KVM will be required
> > > to support timestamping using cycle counters, as KVM now disables
> > > accesses to the PMU counters from the VM.
> > >
> > > Signed-off-by: Shih-Wei Li <shihwei@cs.columbia.edu>
> > > Signed-off-by: Christoffer Dall <cdall@cs.columbia.edu>
> > > Signed-off-by: Andrew Jones <drjones@redhat.com>
> >
> > Acked-by: Christoffer Dall <christoffer.dall@arm.com>
>
> Thanks Christoffer! While running this I just noticed a bug though.
> It seemed my hardware was super-duper fast, because I was missing...
>
> > > +#define PS_PER_SEC (1000 * 1000 * 1000 * 1000U)
> ...an 'L' here ^
>
> I'll send a v2 with that fix now and also add your acked-by.
>
I didn't verify the numeric aspects of the test this time around, but
looked at what the tests do and ran this on a couple of platforms.
I figured we should merge this and we can fix small issues later if they
appear.
Thanks,
Christoffer
next prev parent reply other threads:[~2018-09-03 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:17 [PATCH kvm-unit-tests 0/2] Support micro operation measurement on arm64 Andrew Jones
2018-08-30 14:17 ` [PATCH kvm-unit-tests 1/2] arm/arm64: add GICD_IIDR definition Andrew Jones
2018-08-30 14:17 ` [PATCH kvm-unit-tests 2/2] arm64: add micro-bench Andrew Jones
2018-09-03 11:12 ` Christoffer Dall
2018-09-03 12:11 ` Andrew Jones
2018-09-03 13:14 ` Christoffer Dall [this message]
2018-09-03 14:59 ` Andrew Jones
2018-09-03 15:06 ` Shih-Wei Li
2018-09-03 16:31 ` Andrew Jones
2018-09-04 3:38 ` Shih-Wei Li
2018-09-04 15:02 ` Shih-Wei Li
2018-09-04 15:20 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903131431.GL4029@e113682-lin.lund.arm.com \
--to=christoffer.dall@arm.com \
--cc=cdall@cs.columbia.edu \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=shihwei@cs.columbia.edu \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox