From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len Date: Tue, 4 Sep 2018 09:52:50 -0600 Message-ID: <20180904095250.32e170c5@t450s.home> References: <1535374041-3551-1-git-send-email-liq3ea@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: eric.auger@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, liqiang02@corp.netease.com To: Li Qiang Return-path: In-Reply-To: <1535374041-3551-1-git-send-email-liq3ea@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, 27 Aug 2018 05:47:21 -0700 Li Qiang wrote: > Free the vdev->msi_perm in error path. > > Signed-off-by: Li Qiang > --- > drivers/vfio/pci/vfio_pci_config.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 115a36f6f403..62023b4a373b 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1180,8 +1180,10 @@ static int vfio_msi_cap_len(struct vfio_pci_device *vdev, u8 pos) > return -ENOMEM; > > ret = init_pci_cap_msi_perm(vdev->msi_perm, len, flags); > - if (ret) > + if (ret) { > + kfree(vdev->msi_perm); > return ret; > + } > > return len; > } Fix looks correct to me, I'll queue this for v4.20 with Eric's R-b. Thanks, Alex