From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Subject: Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active Date: Thu, 6 Sep 2018 07:56:40 -0700 Message-ID: <20180906145639.GA1522@linux.intel.com> References: <1536234182-2809-1-git-send-email-brijesh.singh@amd.com> <1536234182-2809-6-git-send-email-brijesh.singh@amd.com> <20180906122423.GA11144@zn.tnic> <20180906135041.GB32336@linux.intel.com> <20180906144342.GB11144@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= To: Borislav Petkov Return-path: Content-Disposition: inline In-Reply-To: <20180906144342.GB11144@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Sep 06, 2018 at 04:43:42PM +0200, Borislav Petkov wrote: > On Thu, Sep 06, 2018 at 06:50:41AM -0700, Sean Christopherson wrote: > > That would prevent adding __decrypted to existing declarations, e.g. > > hv_clock_boot, which would be ugly in its own right. A more generic > > solution would be to add something like __decrypted_exclusive to mark > > I still don't understand why can't there be only a single __decrypted > section and to free that whole section on !SEV. Wouldn't that result in @hv_clock_boot being incorrectly freed in the !SEV case?