From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Subject: Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active Date: Thu, 6 Sep 2018 11:45:03 -0700 Message-ID: <20180906184503.GA4570@linux.intel.com> References: <1536234182-2809-1-git-send-email-brijesh.singh@amd.com> <1536234182-2809-6-git-send-email-brijesh.singh@amd.com> <20180906122423.GA11144@zn.tnic> <20180906135041.GB32336@linux.intel.com> <20180906144342.GB11144@zn.tnic> <20180906145639.GA1522@linux.intel.com> <20180906151938.GD11144@zn.tnic> <20180906155452.GC1522@linux.intel.com> <20180906183334.GF11144@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= To: Borislav Petkov Return-path: Content-Disposition: inline In-Reply-To: <20180906183334.GF11144@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Sep 06, 2018 at 08:33:34PM +0200, Borislav Petkov wrote: > On Thu, Sep 06, 2018 at 08:54:52AM -0700, Sean Christopherson wrote: > > My thought was that we could simply define a second array for the SEV > > case to statically allocate for NR_CPUS since __decrypted has a big > > chunk of memory that would be ununsed anyways[1]. And since the second > > array is only used for SEV it can be freed if !SEV. > > Lemme see if I get it straight: > > __decrypted: > > 4K > > __decrypted_XXX: > > ((num_possible_cpus() * 32) / 4K) pages > > __decrypted_end: > > Am I close? Yep, though because the 4k chunk in __decrypted is @hv_clock_boot that's used for cpus 0-127, __decrypted_XXX would effectively be: (((num_possible_cpus() * 32) / 4k) - 1) pages