From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active Date: Thu, 6 Sep 2018 21:03:42 +0200 Message-ID: <20180906190342.GH11144@zn.tnic> References: <1536234182-2809-1-git-send-email-brijesh.singh@amd.com> <1536234182-2809-6-git-send-email-brijesh.singh@amd.com> <20180906122423.GA11144@zn.tnic> <20180906135041.GB32336@linux.intel.com> <20180906144342.GB11144@zn.tnic> <20180906145639.GA1522@linux.intel.com> <20180906151938.GD11144@zn.tnic> <20180906155452.GC1522@linux.intel.com> <20180906183334.GF11144@zn.tnic> <20180906184503.GA4570@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= To: Sean Christopherson , Brijesh Singh Return-path: Content-Disposition: inline In-Reply-To: <20180906184503.GA4570@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Sep 06, 2018 at 11:45:03AM -0700, Sean Christopherson wrote: > Yep, though because the 4k chunk in __decrypted is @hv_clock_boot > that's used for cpus 0-127, __decrypted_XXX would effectively be: > > (((num_possible_cpus() * 32) / 4k) - 1) pages Ok, sounds like a nice compromise to me. Also, I wonder if using subsections would be even better when adding other things to the decrypted section. I.e., .data..decrypted: ... .data..decrypted.aux: ... .data..decrypted.something_else: and this way keep it still conceptually together by keeping the section namespace clean because we're putting it all under .decrypted's namespace. Hmmm. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --