From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v6 2/5] x86/mm: fix sme_populate_pgd() to update page
 flags
Date: Mon, 10 Sep 2018 14:32:30 +0200
Message-ID: <20180910123230.GF21815@zn.tnic>
References: <1536343050-18532-1-git-send-email-brijesh.singh@amd.com>
 <1536343050-18532-3-git-send-email-brijesh.singh@amd.com>
 <20180910113645.GB21815@zn.tnic>
 <4001638e-6627-7d42-2e72-21c48484022a@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <4001638e-6627-7d42-2e72-21c48484022a@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Mon, Sep 10, 2018 at 07:28:08AM -0500, Brijesh Singh wrote:
> Based on your advice I  was going to submit this series to stable
> separately. This particular issue is not affecting anyone right now. The
> only user to this function is sme_kernel_encrypt() which never updates
> the PTE/PMD entries.  I can update the commit message like this this to
> clarify it.
>
> Enhance the sme_populate_pgd() to update page flags if the PMD/PTE entry
> already exists.

Agreed, except you still need the Fixes: tag to go with the patch. And
that Fixes: tag should point to the patch which added the checks you're
removing, I'd say.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--