From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v6 4/5] x86/kvm: use __decrypted attribute in shared variables Date: Mon, 10 Sep 2018 17:34:52 +0200 Message-ID: <20180910153452.GA20286@zn.tnic> References: <1536343050-18532-1-git-send-email-brijesh.singh@amd.com> <1536343050-18532-5-git-send-email-brijesh.singh@amd.com> <20180910120416.GD21815@zn.tnic> <1536585310.11460.34.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= To: Sean Christopherson Return-path: Content-Disposition: inline In-Reply-To: <1536585310.11460.34.camel@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Sep 10, 2018 at 06:15:10AM -0700, Sean Christopherson wrote: > Heh, that was the original formatting until I asked him to change it: > https://lkml.org/lkml/2018/8/29/809.  Checkpatch throws an error if > there's a newline after 'Commit'.  Though looking at this again, there > shouldn't be a colon after 'Commit' and there should be quotes inside > the parentheses, e.g. this satisfies checkpatch: Yeah, we don't take checkpatch too seriously - only when it makes sense to a human brain. Roughly speaking. In this case, the logic should be, the commit which is the culprit should be visible immediately. Although after the Fixes: tag thing got introduced, that argument is not as important anymore, I'd say. As to the formatting, I think adding this to your git config helps in that regard: [alias] ... one = show -s --pretty='format:%h (\"%s\")' so that you can do: $ git one 368a540e0232 368a540e0232 ("x86/kvmclock: Remove memblock dependency") -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --