From: Borislav Petkov <bp@alien8.de>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org,
dave.hansen@intel.com, sean.j.christopherson@intel.com,
nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com,
shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org,
andriy.shevchenko@linux.intel.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
David Woodhouse <dwmw@amazon.co.uk>,
David Wang <davidwang@zhaoxin.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
Jia Zhang <qianyue.zj@alibaba-inc.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>, He Chen <he.chen@linux.intel.com>,
Lu
Subject: Re: [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits
Date: Wed, 26 Sep 2018 13:36:17 +0200 [thread overview]
Message-ID: <20180926113617.GD5584@zn.tnic> (raw)
In-Reply-To: <20180926111139.GA12037@linux.intel.com>
On Wed, Sep 26, 2018 at 02:11:39PM +0300, Jarkko Sakkinen wrote:
> Thank you. I guess I understand what you want me to do i.e.
>
> + { X86_FEATURE_SGX1, CPUID_EAX, 0, 0x00000012, 0 },
> + { X86_FEATURE_SGX2, CPUID_EAX, 1, 0x00000012, 0 },
> + { X86_FEATURE_ENCLV, CPUID_EAX, 5, 0x00000012, 0 },
> + { X86_FEATURE_ENCLS_C, CPUID_EAX, 6, 0x00000012, 0 },
Yap.
> What puzzles me is that I cannot find any call site for
> get_scattered_cpuid_leaf():
>
> $ git grep get_scattered
> arch/x86/kernel/cpu/cpu.h:extern u32 get_scattered_cpuid_leaf(unsigned int level,
> arch/x86/kernel/cpu/scattered.c:u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf,
> arch/x86/kernel/cpu/scattered.c:EXPORT_SYMBOL_GPL(get_scattered_cpuid_leaf);
That used to be used in kvm last, see b7b27aa011a1df42728d1768fc181d9ce69e6911,
which removed it.
And it got added by
47bdf3378d62 ("x86/cpuid: Provide get_scattered_cpuid_leaf()")
Lemme add those people to CC.
If no one wants it, feel free to decomission it.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next parent reply other threads:[~2018-09-26 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180925130845.9962-1-jarkko.sakkinen@linux.intel.com>
[not found] ` <20180925130845.9962-5-jarkko.sakkinen@linux.intel.com>
[not found] ` <20180925164854.GF23986@zn.tnic>
[not found] ` <20180926111139.GA12037@linux.intel.com>
2018-09-26 11:36 ` Borislav Petkov [this message]
2018-09-27 13:16 ` [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits Jarkko Sakkinen
2018-09-27 13:51 ` Borislav Petkov
2018-09-27 14:52 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926113617.GD5584@zn.tnic \
--to=bp@alien8.de \
--cc=alexander.levin@verizon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=davidwang@zhaoxin.com \
--cc=dwmw@amazon.co.uk \
--cc=he.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qianyue.zj@alibaba-inc.com \
--cc=sean.j.christopherson@intel.com \
--cc=serge.ayoun@intel.com \
--cc=shay.katz-zamir@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox