From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org,
dave.hansen@intel.com, sean.j.christopherson@intel.com,
nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com,
shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org,
andriy.shevchenko@linux.intel.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
David Woodhouse <dwmw@amazon.co.uk>,
David Wang <davidwang@zhaoxin.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
Jia Zhang <qianyue.zj@alibaba-inc.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>, He Chen <he.chen@linux.intel.com>,
Lu
Subject: Re: [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits
Date: Thu, 27 Sep 2018 17:52:38 +0300 [thread overview]
Message-ID: <20180927145238.GA9769@linux.intel.com> (raw)
In-Reply-To: <20180927135139.GB19687@zn.tnic>
On Thu, Sep 27, 2018 at 03:51:39PM +0200, Borislav Petkov wrote:
> On Thu, Sep 27, 2018 at 04:16:42PM +0300, Jarkko Sakkinen wrote:
> > Still kind of leaves me puzzled about the situation :-) Why this wasn't
> > used for example to replace detect_vmx_virtcap()?
>
> I don't understand - detect_vmx_virtcap() is setting X86_FEATURE bits
> based on MSR settings. get_scattered_cpuid_leaf() is regenerating a
> CPUID leaf from the scattered bits.
>
> Looks like apples and oranges to me...
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
Ugh, sorry, I was not thinking clearly :-)
/Jarkko
prev parent reply other threads:[~2018-09-27 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180925130845.9962-1-jarkko.sakkinen@linux.intel.com>
[not found] ` <20180925130845.9962-5-jarkko.sakkinen@linux.intel.com>
[not found] ` <20180925164854.GF23986@zn.tnic>
[not found] ` <20180926111139.GA12037@linux.intel.com>
2018-09-26 11:36 ` [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits Borislav Petkov
2018-09-27 13:16 ` Jarkko Sakkinen
2018-09-27 13:51 ` Borislav Petkov
2018-09-27 14:52 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927145238.GA9769@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.levin@verizon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=davidwang@zhaoxin.com \
--cc=dwmw@amazon.co.uk \
--cc=he.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qianyue.zj@alibaba-inc.com \
--cc=sean.j.christopherson@intel.com \
--cc=serge.ayoun@intel.com \
--cc=shay.katz-zamir@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox