From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH v2 02/33] KVM: PPC: Book3S HV: Remove left-over code in XICS-on-XIVE emulation Date: Tue, 2 Oct 2018 14:49:37 +1000 Message-ID: <20181002044937.GF1886@umbus.fritz.box> References: <1538127963-15645-1-git-send-email-paulus@ozlabs.org> <1538127963-15645-3-git-send-email-paulus@ozlabs.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b8GWCKCLzrXbuNet" Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Paul Mackerras Return-path: Content-Disposition: inline In-Reply-To: <1538127963-15645-3-git-send-email-paulus@ozlabs.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org --b8GWCKCLzrXbuNet Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 28, 2018 at 07:45:32PM +1000, Paul Mackerras wrote: > This removes code that clears the external interrupt pending bit in > the pending_exceptions bitmap. This is left over from an earlier > iteration of the code where this bit was set when an escalation > interrupt arrived in order to wake the vcpu from cede. Currently > we set the vcpu->arch.irq_pending flag instead for this purpose. > Therefore there is no need to do anything with the pending_exceptions > bitmap. >=20 > Signed-off-by: Paul Mackerras Reviewed-by: David Gibson > --- > arch/powerpc/kvm/book3s_xive_template.c | 8 -------- > 1 file changed, 8 deletions(-) >=20 > diff --git a/arch/powerpc/kvm/book3s_xive_template.c b/arch/powerpc/kvm/b= ook3s_xive_template.c > index 203ea65..033363d 100644 > --- a/arch/powerpc/kvm/book3s_xive_template.c > +++ b/arch/powerpc/kvm/book3s_xive_template.c > @@ -280,14 +280,6 @@ X_STATIC unsigned long GLUE(X_PFX,h_xirr)(struct kvm= _vcpu *vcpu) > /* First collect pending bits from HW */ > GLUE(X_PFX,ack_pending)(xc); > =20 > - /* > - * Cleanup the old-style bits if needed (they may have been > - * set by pull or an escalation interrupts). > - */ > - if (test_bit(BOOK3S_IRQPRIO_EXTERNAL, &vcpu->arch.pending_exceptions)) > - clear_bit(BOOK3S_IRQPRIO_EXTERNAL, > - &vcpu->arch.pending_exceptions); > - > pr_devel(" new pending=3D0x%02x hw_cppr=3D%d cppr=3D%d\n", > xc->pending, xc->hw_cppr, xc->cppr); > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --b8GWCKCLzrXbuNet Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAluy+OEACgkQbDjKyiDZ s5K6ZhAAwgX0yEBTyUT+cFn2zXKK1oQ8C1eLCTRIWcEsx6nrCt/44/fBEyvn7moG oXjoALUWiiKCxwlZqBb8G4tAe9UHTcCRHlGCglt57F7YPS0yTneMSZrUCnqWzglb BnSLcsJalNgI84sI7JeiEDfDpVjh/c0NOPI2RPRlv9FuB/gTZTuePBhLDSH2u3y2 fcVJh4ZeMbmOULTlOKTHzgBb1BZWSdyqz1WCJY4bVayUA/CVcuMfngEsMxiQ6McD ji+tRxPMVNrJZJWr0ZFxifPF3D4BfCaJlYX/yMj/0Lgw9eWodiaA0OYZsqOlf2Uv NIDn6SIzQ7MeEyvtbetR517eZ6ZHL12BwCg67MPCbEbd8bytSxX5d8ANvd2NaPTw wQUXCwcnBBW1IEaTE2BuF+XAgND34bR2y4QykARQ5lKQEe1UDhxqT+lFKj0Xnmex /nxOWOnHMQHNijBw49cxDlsJsw/aB9cFnsAJKgpmObIKmxRI/D1Lgjlmn7nZ/XkS pAg44kfaxr55L55qqRfTnBjO4++YVpfqPNd6b5n5zcvYUQlIbpc6UxeYVBi9esOF VemQLbB/O2U98aaKWZV4/mN4iY501dxJDvTlPPz6bh6g9LXSNz8OxMazlkGBwHZv eA3Se8lGOn4V9mJwWXYEutwlGCONPIs7tlv2YiKADGiCgc3BTi0= =Gnco -----END PGP SIGNATURE----- --b8GWCKCLzrXbuNet--