From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yang Subject: Re: [PATCH] kvm/x86 : avoid shifting signed 32-bit value by 31 bits Date: Sat, 6 Oct 2018 02:11:27 +0000 Message-ID: <20181006021127.zuic7afw42b3hzw2@master> References: <1538675238-27356-1-git-send-email-penghao122@sina.com.cn> Reply-To: Wei Yang Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, joro@8bytes.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, Peng Hao To: Peng Hao Return-path: Content-Disposition: inline In-Reply-To: <1538675238-27356-1-git-send-email-penghao122@sina.com.cn> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Oct 04, 2018 at 01:47:18PM -0400, Peng Hao wrote: > >From: Peng Hao > > modify AVIC_LOGICAL_ID_ENTRY_VALID_MASK to unsigned > >Signed-off-by: Peng Hao >--- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c >index d96092b..bf1ded4 100644 >--- a/arch/x86/kvm/svm.c >+++ b/arch/x86/kvm/svm.c >@@ -262,7 +262,7 @@ struct amd_svm_iommu_ir { > }; > > #define AVIC_LOGICAL_ID_ENTRY_GUEST_PHYSICAL_ID_MASK (0xFF) >-#define AVIC_LOGICAL_ID_ENTRY_VALID_MASK (1 << 31) >+#define AVIC_LOGICAL_ID_ENTRY_VALID_MASK (1UL << 31) It is reasonable to change to unsigned, while not necessary to unsigned long? > > #define AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK (0xFFULL) > #define AVIC_PHYSICAL_ID_ENTRY_BACKING_PAGE_MASK (0xFFFFFFFFFFULL << 12) >-- >1.8.3.1 > -- Wei Yang Help you, Help me