From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] KVM: X86: Add missing KVM_AMD dependency Date: Mon, 8 Oct 2018 19:32:16 +0200 Message-ID: <20181008173216.GJ6490@zn.tnic> References: <1538765165-19177-1-git-send-email-linux@roeck-us.net> <749a21f9-ad88-af0e-bed7-b505ac57568d@redhat.com> <20181005220325.GA24365@roeck-us.net> <713d35b9-5dd5-284f-b514-7d2295a2db34@redhat.com> <5e1de49e-9ec5-b11b-d38b-845d0274dc03@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Paolo Bonzini , Guenter Roeck , Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: "Singh, Brijesh" Return-path: Content-Disposition: inline In-Reply-To: <5e1de49e-9ec5-b11b-d38b-845d0274dc03@amd.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Oct 08, 2018 at 02:52:46PM +0000, Singh, Brijesh wrote: > Does it make sense to move all the SEV specific code in svm-sev.c ? > I am looking to add SEV migration support very soon, and can see > myself adding more SEV command handling which will grow svm.c further. Amen to that - svm.c is pretty huge already. And if you end up moving facilities, you can simply call it sev.c Just my 2¢. Thx. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)