From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH] s390/cio: make vfio_ccw_io_region static Date: Mon, 15 Oct 2018 15:39:46 +0200 Message-ID: <20181015153946.6c9b0e49.cohuck@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Halil Pasic , Eric Farman , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Sebastian Ott Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, 15 Oct 2018 13:31:39 +0200 (CEST) Sebastian Ott wrote: > Fix the following sparse warning: > drivers/s390/cio/vfio_ccw_drv.c:25:19: warning: symbol 'vfio_ccw_io_region' > was not declared. Should it be static? Hm, it seems my workflow needs more static checkers. > > Signed-off-by: Sebastian Ott > --- > drivers/s390/cio/vfio_ccw_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c > index f47d16b5810b..edbf542d82af 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -22,7 +22,7 @@ > #include "vfio_ccw_private.h" > > struct workqueue_struct *vfio_ccw_work_q; > -struct kmem_cache *vfio_ccw_io_region; > +static struct kmem_cache *vfio_ccw_io_region; > > /* > * Helpers Thanks, applied.