From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. David Alan Gilbert" Subject: Re: [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state Date: Wed, 31 Oct 2018 18:59:30 +0000 Message-ID: <20181031185930.GC2403@work-vm> References: <20180916124631.39016-1-liran.alon@oracle.com> <80DAB33E-A982-4903-AEBA-F71AB2E8AFC3@oracle.com> <5F34DE35-D1EE-441A-87A1-379C7A04AFE7@oracle.com> <20181031181759.GR3902@habkost.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Eduardo Habkost , kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, Paolo Bonzini , jmattson@google.com, rth@twiddle.net To: Liran Alon Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org * Liran Alon (liran.alon@oracle.com) wrote: >=20 >=20 > > On 31 Oct 2018, at 20:19, Paolo Bonzini wrote: > >=20 > > On 31/10/2018 19:17, Eduardo Habkost wrote: > >> On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote: > >>> Ping. > >>> Patch was submitted almost two months ago and I haven=E2=80=99t see= n any respond for the v2 of this series. > >> Sorry for the long delay. This was on my queue of patches to be > >> reviewed, but I'm failing to keep up to the rate of incoming > >> patches. I will try to review the series next week. > >=20 > > I have already reviewed it; unfortunately I have missed the soft free= ze > > for posting the version I had also been working on when Liran posted > > these patches. > >=20 > > Paolo >=20 > Paolo, note that this is v2 of this patch series. It=E2=80=99s not the = one you have already reviewed. > It now correctly handles the case you mentioned in review of v1 of migr= ating with various nested_state buffer sizes. > The following scenarios were tested: > (a) src and dest have same nested state size. > =3D=3D> Migration succeeds. > (b) src don't have nested state while dest do. > =3D=3D> Migration succeed and src don't send it's nested state. > (c) src have nested state while dest don't. > =3D=3D> Migration fails as it cannot restore nested state. > (d) dest have bigger max nested state size than src > =3D=3D> Migration succeeds. > (e) dest have smaller max nested state size than src but enough to stor= e it's saved nested state > =3D=3D> Migration succeeds > (f) dest have smaller max nested state size than src but not enough to = store it's saved nested state > =3D=3D> Migration fails Is it possible to tell these limits before the start of the migration, or do we only find out that a nested migration won't work by trying it? Dave > -Liran >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK