From: "Michael S. Tsirkin" <mst@redhat.com>
To: Vitaly Mayatskih <v.mayatskih@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Add vhost_blk driver
Date: Fri, 2 Nov 2018 16:38:19 -0400 [thread overview]
Message-ID: <20181102163809-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAGF4SLj0TtW_kP935UdqswjT9qaznh_BR7sxW2ALozy7yTJ8vg@mail.gmail.com>
On Fri, Nov 02, 2018 at 03:24:13PM -0400, Vitaly Mayatskih wrote:
> On Fri, Nov 2, 2018 at 2:36 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> > > + if (type == VIRTIO_BLK_T_GET_ID) {
> > > + char s[] = "vhost_blk";
> >
> > Isn't this supposed to return the serial #?
>
> Yes, that gets a bit tricky here... Disk serial number is specified in
> QEMU command line parameters, so it needs to be passed to vhost_blk
> when qemu attaches the disk backend. That can be done (now? in a
> following incremental patch?).
I'add an ioctl now.
> Also other vhost work does the same with GET_ID, if that's matter.
>
> I'll fix the rest, thanks for review!
>
> --
> wbr, Vitaly
next prev parent reply other threads:[~2018-11-02 20:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 18:21 [PATCH 0/1] vhost: add vhost_blk driver Vitaly Mayatskikh
2018-11-02 18:21 ` [PATCH 1/1] Add " Vitaly Mayatskikh
2018-11-02 18:36 ` Michael S. Tsirkin
2018-11-02 19:24 ` Vitaly Mayatskih
2018-11-02 20:38 ` Michael S. Tsirkin [this message]
2018-11-03 2:50 ` kbuild test robot
2018-11-06 16:03 ` Stefan Hajnoczi
2018-11-06 19:47 ` Vitaly Mayatskih
2018-11-02 18:26 ` [PATCH 0/1] vhost: add " Michael S. Tsirkin
2018-11-02 18:31 ` Vitaly Mayatskih
2018-11-05 14:02 ` Christian Borntraeger
2018-11-05 14:21 ` Vitaly Mayatskih
2018-11-06 15:40 ` Stefan Hajnoczi
2018-11-06 18:46 ` Denis Lunev
2018-11-06 20:08 ` Vitaly Mayatskih
2018-11-04 11:57 ` Maxim Levitsky
2018-11-04 16:40 ` Vitaly Mayatskih
2018-11-05 11:55 ` Maxim Levitsky
2018-11-05 3:00 ` Jason Wang
2018-11-05 3:23 ` Vitaly Mayatskih
2018-11-06 2:45 ` Jason Wang
2018-11-06 2:56 ` Vitaly Mayatskih
2018-11-06 7:13 ` Christoph Hellwig
2018-11-06 21:41 ` Paolo Bonzini
2018-11-05 15:48 ` Christian Borntraeger
2018-11-05 16:15 ` Vitaly Mayatskih
2018-11-06 15:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102163809-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=v.mayatskih@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox