From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] vfio/mdev: add static modifier to add_mdev_supported_type Date: Wed, 12 Dec 2018 15:45:36 -0700 Message-ID: <20181212154536.3f76dfaf@x1.home> References: <20181113084543.9543-1-paolocretaro@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kwankhede@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Cretaro Return-path: In-Reply-To: <20181113084543.9543-1-paolocretaro@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, 13 Nov 2018 09:45:43 +0100 Paolo Cretaro wrote: > Set add_mdev_supported_type as static since it is only used within > mdev_sysfs.c. > This fixes -Wmissing-prototypes gcc warning. > > Signed-off-by: Paolo Cretaro > --- > drivers/vfio/mdev/mdev_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c > index 249472f05509..ce5dd219f2c8 100644 > --- a/drivers/vfio/mdev/mdev_sysfs.c > +++ b/drivers/vfio/mdev/mdev_sysfs.c > @@ -92,8 +92,8 @@ static struct kobj_type mdev_type_ktype = { > .release = mdev_type_release, > }; > > -struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent, > - struct attribute_group *group) > +static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent, > + struct attribute_group *group) > { > struct mdev_type *type; > int ret; Applied to vfio next branch with Cornlia's review. Thanks, Alex