From: Michael Mueller <mimu@linux.ibm.com>
To: KVM Mailing List <kvm@vger.kernel.org>
Cc: Linux-S390 Mailing List <linux-s390@vger.kernel.org>,
linux-kernel@vger.kernel.org,
kvm390-list@tuxmaker.boeblingen.de.ibm.com,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
Michael Mueller <mimu@linux.ibm.com>
Subject: [PATCH v5 12/15] KVM: s390: do not restore IAM immediately before SIE entry
Date: Wed, 19 Dec 2018 20:17:53 +0100 [thread overview]
Message-ID: <20181219191756.57973-13-mimu@linux.ibm.com> (raw)
In-Reply-To: <20181219191756.57973-1-mimu@linux.ibm.com>
The IAM shall no be restored when deliverable interruptions are
delivered to vcpus by means of the PSW swap mechanism. That would
trigger the GIB alert millicode although we know that SIE will be
able to handle the pending interruption on entry.
Signed-off-by: Michael Mueller <mimu@linux.ibm.com>
---
arch/s390/kvm/interrupt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 8307717e3caf..48a93f5e5333 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -328,11 +328,11 @@ static unsigned long disable_iscs(struct kvm_vcpu *vcpu,
return active_mask;
}
-static unsigned long deliverable_irqs(struct kvm_vcpu *vcpu)
+static unsigned long deliverable_irqs(struct kvm_vcpu *vcpu, u16 irq_flags)
{
unsigned long active_mask;
- active_mask = pending_irqs(vcpu, IRQ_MASK_ALL);
+ active_mask = pending_irqs(vcpu, irq_flags);
if (!active_mask)
return 0;
@@ -1090,7 +1090,7 @@ int kvm_s390_ext_call_pending(struct kvm_vcpu *vcpu)
int kvm_s390_vcpu_has_irq(struct kvm_vcpu *vcpu, int exclude_stop)
{
- if (deliverable_irqs(vcpu))
+ if (deliverable_irqs(vcpu, IRQ_MASK_ALL | IRQ_FLAG_IAM))
return 1;
if (kvm_cpu_has_pending_timer(vcpu))
@@ -1262,7 +1262,7 @@ int __must_check kvm_s390_deliver_pending_interrupts(struct kvm_vcpu *vcpu)
if (cpu_timer_irq_pending(vcpu))
set_bit(IRQ_PEND_EXT_CPU_TIMER, &li->pending_irqs);
- while ((irqs = deliverable_irqs(vcpu)) && !rc) {
+ while ((irqs = deliverable_irqs(vcpu, IRQ_MASK_ALL)) && !rc) {
/* bits are in the reverse order of interrupt priority */
irq_type = find_last_bit(&irqs, IRQ_PEND_COUNT);
switch (irq_type) {
--
2.13.4
next prev parent reply other threads:[~2018-12-19 19:17 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 19:17 [PATCH v5 00/15] KVM: s390: make use of the GIB Michael Mueller
2018-12-19 19:17 ` [PATCH v5 01/15] KVM: s390: unregister debug feature on failing arch init Michael Mueller
2018-12-19 20:10 ` Cornelia Huck
2018-12-20 7:49 ` Michael Mueller
2018-12-20 7:55 ` Christian Borntraeger
2018-12-19 19:17 ` [PATCH v5 02/15] KVM: s390: coding style issue kvm_s390_gisa_init/clear() Michael Mueller
2018-12-19 20:13 ` Cornelia Huck
2019-01-02 16:50 ` Pierre Morel
2019-01-07 16:16 ` Michael Mueller
2018-12-19 19:17 ` [PATCH v5 03/15] KVM: s390: factor out nullify_gisa() Michael Mueller
2018-12-19 19:17 ` [PATCH v5 04/15] KVM: s390: use pending_irqs_no_gisa() where appropriate Michael Mueller
2018-12-19 20:16 ` Cornelia Huck
2019-01-02 16:52 ` Pierre Morel
2018-12-19 19:17 ` [PATCH v5 05/15] KVM: s390: unify pending_irqs() and pending_irqs_no_gisa() Michael Mueller
2018-12-20 10:09 ` Michael Mueller
2018-12-20 11:06 ` Cornelia Huck
2018-12-20 11:49 ` Michael Mueller
2018-12-20 12:15 ` Halil Pasic
2018-12-20 12:21 ` Cornelia Huck
2018-12-20 12:33 ` Michael Mueller
2018-12-20 15:43 ` pierre morel
2018-12-20 16:40 ` Michael Mueller
2018-12-19 19:17 ` [PATCH v5 06/15] KVM: s390: remove prefix kvm_s390_gisa_ from static inline functions Michael Mueller
2018-12-20 12:24 ` Cornelia Huck
2018-12-20 14:37 ` Michael Mueller
2018-12-19 19:17 ` [PATCH v5 07/15] s390/cio: add function chsc_sgib() Michael Mueller
2018-12-19 19:17 ` [PATCH v5 08/15] KVM: s390: add the GIB and its related life-cyle functions Michael Mueller
2018-12-20 12:28 ` Cornelia Huck
2019-01-03 9:49 ` Pierre Morel
2019-01-07 16:25 ` Michael Mueller
2018-12-19 19:17 ` [PATCH v5 09/15] KVM: s390: add kvm reference to struct sie_page2 Michael Mueller
2018-12-19 19:17 ` [PATCH v5 10/15] KVM: s390: add functions to (un)register GISC with GISA Michael Mueller
2018-12-20 14:32 ` Michael Mueller
2019-01-02 17:29 ` Pierre Morel
2019-01-02 18:26 ` Pierre Morel
2019-01-04 13:19 ` Cornelia Huck
2019-01-07 17:38 ` Michael Mueller
2019-01-08 10:34 ` Cornelia Huck
2019-01-08 13:07 ` Michael Mueller
2019-01-08 13:35 ` Cornelia Huck
2019-01-08 13:36 ` Halil Pasic
2019-01-08 13:41 ` Cornelia Huck
2019-01-08 14:23 ` Halil Pasic
2018-12-19 19:17 ` [PATCH v5 11/15] KVM: s390: restore IAM in get_ipm() when IPM is clean Michael Mueller
2019-01-03 15:06 ` Pierre Morel
2019-01-07 18:17 ` Michael Mueller
2019-01-06 23:32 ` Halil Pasic
2019-01-08 8:06 ` Michael Mueller
2018-12-19 19:17 ` Michael Mueller [this message]
2019-01-03 15:00 ` [PATCH v5 12/15] KVM: s390: do not restore IAM immediately before SIE entry Pierre Morel
2019-01-07 17:53 ` Michael Mueller
2018-12-19 19:17 ` [PATCH v5 13/15] KVM: s390: add function process_gib_alert_list() Michael Mueller
2019-01-03 14:43 ` Pierre Morel
2019-01-07 19:18 ` Michael Mueller
2019-01-08 14:27 ` Halil Pasic
2019-01-09 11:39 ` Pierre Morel
2019-01-07 19:19 ` Michael Mueller
2019-01-08 6:37 ` Heiko Carstens
2019-01-08 12:59 ` Halil Pasic
2019-01-08 15:21 ` Michael Mueller
2019-01-08 18:34 ` Halil Pasic
2019-01-09 12:14 ` Pierre Morel
2019-01-09 13:10 ` Halil Pasic
2019-01-09 14:49 ` Pierre Morel
2019-01-09 16:18 ` Halil Pasic
2018-12-19 19:17 ` [PATCH v5 14/15] KVM: s390: add and wire function gib_alert_irq_handler() Michael Mueller
2019-01-03 15:16 ` Pierre Morel
2019-01-08 10:06 ` Michael Mueller
2019-01-09 12:35 ` Pierre Morel
2018-12-19 19:17 ` [PATCH v5 15/15] KVM: s390: start using the GIB Michael Mueller
2019-01-02 17:45 ` Pierre Morel
2019-01-08 9:03 ` Michael Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219191756.57973-13-mimu@linux.ibm.com \
--to=mimu@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm390-list@tuxmaker.boeblingen.de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox