From: Eduardo Habkost <ehabkost@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jörg Rödel" <joro@8bytes.org>,
"Andre Przywara" <andre.przywara@arm.com>,
"kvm ML" <kvm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Eric Blake" <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH -v2] target-i386: Reenable RDTSCP support on Opteron_G[345] CPU models CPU models
Date: Thu, 20 Dec 2018 10:10:18 -0200 [thread overview]
Message-ID: <20181220121018.GM19442@habkost.net> (raw)
In-Reply-To: <20181212200803.GG6653@zn.tnic>
On Wed, Dec 12, 2018 at 09:08:03PM +0100, Borislav Petkov wrote:
> On Wed, Dec 12, 2018 at 05:52:35PM -0200, Eduardo Habkost wrote:
> > Why did you remove this entry from PC_COMPAT_2_4?
> >
> > We must keep compatibility with old behavior of Opteron_G2 on
> > pc-2.4, even if the old behavior was incorrect.
>
> Ok, hunk reverted. v2 below.
>
> Thx.
>
> ---
> From: Borislav Petkov <bp@suse.de>
>
> The missing functionality was added ~3 years ago with the Linux commit
>
> 46896c73c1a4 ("KVM: svm: add support for RDTSCP")
>
> so reenable RDTSCP support on those CPU models.
>
> Opteron_G2 - being family 15, model 6, doesn't have RDTSCP support
> (the real hardware doesn't have it. K8 got RDTSCP support with the NPT
> models, i.e., models >= 0x40).
>
> Document the host's minimum required kernel version, while at it.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Queued, thanks.
--
Eduardo
next prev parent reply other threads:[~2018-12-20 12:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:13 kvm: RDTSCP on AMD Borislav Petkov
2018-12-10 18:37 ` Eduardo Habkost
2018-12-10 18:41 ` Borislav Petkov
2018-12-10 19:06 ` Eduardo Habkost
2018-12-10 19:42 ` Borislav Petkov
2018-12-10 20:08 ` Eduardo Habkost
2018-12-10 20:39 ` Borislav Petkov
2018-12-11 10:38 ` Daniel P. Berrangé
2018-12-11 11:55 ` Eduardo Habkost
2018-12-11 14:35 ` Daniel P. Berrangé
2018-12-11 15:23 ` Paolo Bonzini
2018-12-11 15:30 ` Daniel P. Berrangé
2018-12-11 16:14 ` [PATCH] target-i386: Reenable RDTSCP support on Opteron_G[345] CPU models Borislav Petkov
2018-12-12 19:52 ` Eduardo Habkost
2018-12-12 20:08 ` [PATCH -v2] target-i386: Reenable RDTSCP support on Opteron_G[345] CPU models " Borislav Petkov
2018-12-20 12:10 ` Eduardo Habkost [this message]
2018-12-10 19:47 ` kvm: RDTSCP on AMD Eduardo Habkost
2018-12-10 20:16 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220121018.GM19442@habkost.net \
--to=ehabkost@redhat.com \
--cc=andre.przywara@arm.com \
--cc=berrange@redhat.com \
--cc=bp@alien8.de \
--cc=eblake@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox