Re: [RFC PATCH V2 3/3] vhost: access vq metadata through kernel virtual address

David Miller
2018-12-28T19:34:44Z

From: Jason Wang <jasowang@redhat.com>
Date: Fri, 28 Dec 2018 15:55:37 +0800

> +static int vhost_invalidate_vmap(struct vhost_virtqueue *vq,
> + struct vhost_vmap *map,
> + unsigned long uaddr,
> + unsigned long start,
> + unsigned long end,
> + bool blockable)
> +{
> + if (start < uaddr && end >= uaddr) {
> + if (!blockable)
> + return -EAGAIN;
> + mutex_lock(&vq->mutex);
> + if (map->addr)
> + vunmap(map->unmap_addr);
> + map->addr = NULL;
> + map->unmap_addr = NULL;
> + mutex_unlock(&vq->mutex);
> + }
> +
> + return 0;
> +}

What are the rules for these invalidate operations?

Can there be partial overlaps? If so, wouldn't you need some way of
keeping track of the partially overlapping unmaps so that once all of
the invalidates covering the range occur you properly cleanup and do
the vunmap()?