From: Cornelia Huck <cohuck@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
mst@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pbonzini@redhat.com,
dgilbert@redhat.com
Subject: Re: [PATCH v1 1/2] virtio_pci: use queue idx instead of array idx to set up the vq
Date: Thu, 3 Jan 2019 10:57:20 +0100 [thread overview]
Message-ID: <20190103105720.48e6c2c6.cohuck@redhat.com> (raw)
In-Reply-To: <1545963986-11280-2-git-send-email-wei.w.wang@intel.com>
On Fri, 28 Dec 2018 10:26:25 +0800
Wei Wang <wei.w.wang@intel.com> wrote:
> When find_vqs, there will be no vq[i] allocation if its corresponding
> names[i] is NULL. For example, the caller may pass in names[i] (i=4)
> with names[2] being NULL because the related feature bit is turned off,
> so technically there are 3 queues on the device, and name[4] should
> correspond to the 3rd queue on the device.
>
> So we use queue_idx as the queue index, which is increased only when the
> queue exists.
>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> ---
> drivers/virtio/virtio_pci_common.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-01-03 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 2:26 [PATCH v1 0/2] Virtio: fix some vq allocation issues Wei Wang
2018-12-28 2:26 ` [PATCH v1 1/2] virtio_pci: use queue idx instead of array idx to set up the vq Wei Wang
2019-01-03 9:57 ` Cornelia Huck [this message]
2019-01-09 16:29 ` Christian Borntraeger
2018-12-28 2:26 ` [PATCH v1 2/2] virtio: don't allocate vqs when names[i] = NULL Wei Wang
2019-01-03 9:59 ` Cornelia Huck
2019-01-09 16:30 ` Christian Borntraeger
2018-12-28 7:57 ` [PATCH v1 0/2] Virtio: fix some vq allocation issues Christian Borntraeger
2018-12-29 2:45 ` Wang, Wei W
2018-12-30 6:06 ` Halil Pasic
2018-12-31 6:03 ` Wang, Wei W
2018-12-31 23:40 ` Halil Pasic
2019-01-02 9:53 ` Cornelia Huck
2019-01-02 13:23 ` Cornelia Huck
2019-01-02 15:59 ` Halil Pasic
2019-01-02 18:02 ` Cornelia Huck
2019-01-02 19:13 ` Halil Pasic
2019-01-02 13:56 ` Halil Pasic
2019-01-03 6:18 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103105720.48e6c2c6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox