From: Cornelia Huck <cohuck@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Laura Abbott <labbott@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error
Date: Tue, 8 Jan 2019 10:47:32 +0100 [thread overview]
Message-ID: <20190108104732.42c1e2a9.cohuck@redhat.com> (raw)
In-Reply-To: <1546916883-25911-1-git-send-email-yamada.masahiro@socionext.com>
On Tue, 8 Jan 2019 12:08:03 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> drivers/vfio/pci/vfio_pci_nvlink2.c cannot be compiled for in-tree
> building.
>
> CC drivers/vfio/pci/vfio_pci_nvlink2.o
> In file included from drivers/vfio/pci/trace.h:102,
> from drivers/vfio/pci/vfio_pci_nvlink2.c:29:
> ./include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory
> #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> ^
> compilation terminated.
> make[1]: *** [scripts/Makefile.build;277: drivers/vfio/pci/vfio_pci_nvlink2.o] Error 1
>
> To fix the build error, let's tell include/trace/define_trace.h the
> location of drivers/vfio/pci/trace.h
>
> Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver")
> Reported-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/vfio/pci/trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/pci/trace.h b/drivers/vfio/pci/trace.h
> index 228ccdb..4d13e51 100644
> --- a/drivers/vfio/pci/trace.h
> +++ b/drivers/vfio/pci/trace.h
> @@ -94,7 +94,7 @@ TRACE_EVENT(vfio_pci_npu2_mmap,
> #endif /* _TRACE_VFIO_PCI_H */
>
> #undef TRACE_INCLUDE_PATH
> -#define TRACE_INCLUDE_PATH .
> +#define TRACE_INCLUDE_PATH ../../drivers/vfio/pci
> #undef TRACE_INCLUDE_FILE
> #define TRACE_INCLUDE_FILE trace
>
I think both this and the other fix option via the Makefile are fine
(even though I still slightly prefer the latter), so I'll leave the
choice to the maintainer.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-01-08 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 3:08 [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error Masahiro Yamada
2019-01-08 9:47 ` Cornelia Huck [this message]
2019-01-08 19:28 ` Alex Williamson
2019-01-10 14:47 ` Steven Rostedt
2019-01-11 1:13 ` Alexey Kardashevskiy
2019-01-11 1:41 ` Alex Williamson
2019-01-11 1:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108104732.42c1e2a9.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox