From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error Date: Tue, 8 Jan 2019 10:47:32 +0100 Message-ID: <20190108104732.42c1e2a9.cohuck@redhat.com> References: <1546916883-25911-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alex Williamson , kvm@vger.kernel.org, Laura Abbott , Alexey Kardashevskiy , Michael Ellerman , linux-kernel@vger.kernel.org To: Masahiro Yamada Return-path: In-Reply-To: <1546916883-25911-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, 8 Jan 2019 12:08:03 +0900 Masahiro Yamada wrote: > drivers/vfio/pci/vfio_pci_nvlink2.c cannot be compiled for in-tree > building. > > CC drivers/vfio/pci/vfio_pci_nvlink2.o > In file included from drivers/vfio/pci/trace.h:102, > from drivers/vfio/pci/vfio_pci_nvlink2.c:29: > ./include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory > #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > ^ > compilation terminated. > make[1]: *** [scripts/Makefile.build;277: drivers/vfio/pci/vfio_pci_nvlink2.o] Error 1 > > To fix the build error, let's tell include/trace/define_trace.h the > location of drivers/vfio/pci/trace.h > > Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver") > Reported-by: Laura Abbott > Signed-off-by: Masahiro Yamada > --- > > drivers/vfio/pci/trace.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/trace.h b/drivers/vfio/pci/trace.h > index 228ccdb..4d13e51 100644 > --- a/drivers/vfio/pci/trace.h > +++ b/drivers/vfio/pci/trace.h > @@ -94,7 +94,7 @@ TRACE_EVENT(vfio_pci_npu2_mmap, > #endif /* _TRACE_VFIO_PCI_H */ > > #undef TRACE_INCLUDE_PATH > -#define TRACE_INCLUDE_PATH . > +#define TRACE_INCLUDE_PATH ../../drivers/vfio/pci > #undef TRACE_INCLUDE_FILE > #define TRACE_INCLUDE_FILE trace > I think both this and the other fix option via the Makefile are fine (even though I still slightly prefer the latter), so I'll leave the choice to the maintainer. Reviewed-by: Cornelia Huck