From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [PATCH tip/core/rcu 2/2] virt/kvm: Replace spin_is_locked() with lockdep Date: Thu, 10 Jan 2019 10:52:00 -0800 Message-ID: <20190110185200.GU1215@linux.ibm.com> References: <20190109222120.GA13904@linux.ibm.com> <20190109222144.14270-2-paulmck@linux.ibm.com> Reply-To: paulmck@linux.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm@vger.kernel.org To: Paolo Bonzini Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Jan 09, 2019 at 11:36:23PM +0100, Paolo Bonzini wrote: > On 09/01/19 23:21, Paul E. McKenney wrote: > > lockdep_assert_held() is better suited to checking locking requirements, > > since it only checks if the current thread holds the lock regardless of > > whether someone else does. This is also a step towards possibly removing > > spin_is_locked(). > > > > Signed-off-by: Paul E. McKenney > > Cc: Paolo Bonzini > > Cc: "Radim Krčmář" > > Cc: > > --- > > virt/kvm/kvm_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 1f888a103f78..ec758bb7eeba 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -4078,7 +4078,7 @@ static int kvm_suspend(void) > > static void kvm_resume(void) > > { > > if (kvm_usage_count) { > > - WARN_ON(raw_spin_is_locked(&kvm_count_lock)); > > + lockdep_assert_held(&kvm_count_lock); > > hardware_enable_nolock(NULL); > > } > > } > > Acked-by: Paolo Bonzini Applied, thank you! Thanx, Paul