From: Steven Rostedt <rostedt@goodmis.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org, Laura Abbott <labbott@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error
Date: Thu, 10 Jan 2019 20:49:15 -0500 [thread overview]
Message-ID: <20190110204915.1cab2b78@vmware.local.home> (raw)
In-Reply-To: <9b1c9668-98cb-2a30-2fb0-b797b47aa9b6@ozlabs.ru>
On Fri, 11 Jan 2019 12:13:35 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> > The words in TRACE_INCLUDE_PATH can be updated by C preprocessor defines. For
> > example, if for some reason you had:
> >
> > #define pci special_pci
> >
> > The above would turn into:
> >
> > ../../drivers/vfio/special_pci
> >
> > and it wont build, and you will be left scratching your head wondering why.
>
> Lovely :) imho it is +1 for
> CFLAGS_vfio_pci_nvlink2.o += -I$(src)
> and a comment.
A more realistic example is:
#define pci 1
which I hit when I first tried to do it this way when I first
implemented this code (not with "pci" but a similar word).
I'll leave this up to the maintainers of the code to decide which way
they want to do it, as they are the ones that have to deal with the
fallout if something goes wrong ;-)
-- Steve
prev parent reply other threads:[~2019-01-11 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 3:08 [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error Masahiro Yamada
2019-01-08 9:47 ` Cornelia Huck
2019-01-08 19:28 ` Alex Williamson
2019-01-10 14:47 ` Steven Rostedt
2019-01-11 1:13 ` Alexey Kardashevskiy
2019-01-11 1:41 ` Alex Williamson
2019-01-11 1:49 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110204915.1cab2b78@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox