From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH][next] KVM: x86: Fix bit shifting in update_intel_pt_cfg Date: Fri, 11 Jan 2019 14:39:45 +0100 Message-ID: <20190111133944.GC14852@flask> References: <20181226204059.GA11391@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Luwei Kang , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "Gustavo A. R. Silva" Return-path: Content-Disposition: inline In-Reply-To: <20181226204059.GA11391@embeddedor> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 2018-12-26 14:40-0600, Gustavo A. R. Silva: > ctl_bitmask in pt_desc is of type u64. When an integer like 0xf is > being left shifted more than 32 bits, the behavior is undefined. > > Fix this by adding suffix ULL to integer 0xf. > > Addresses-Coverity-ID: 1476095 ("Bad bit shift operation") > Fixes: 6c0f0bba85a0 ("KVM: x86: Introduce a function to initialize the PT configuration") > Signed-off-by: Gustavo A. R. Silva > --- Applied, thanks.