From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. David Alan Gilbert" Subject: Re: [PATCH v2 1/3] migration: introduce pages-per-second Date: Wed, 23 Jan 2019 12:51:20 +0000 Message-ID: <20190123125111.GE5771@work-vm> References: <20190111063732.10484-1-xiaoguangrong@tencent.com> <20190111063732.10484-2-xiaoguangrong@tencent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, Xiao Guangrong , qemu-devel@nongnu.org, peterx@redhat.com, quintela@redhat.com, wei.w.wang@intel.com, cota@braap.org, guangrong.xiao@gmail.com, pbonzini@redhat.com To: Eric Blake Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org * Eric Blake (eblake@redhat.com) wrote: > On 1/11/19 12:37 AM, guangrong.xiao@gmail.com wrote: > > From: Xiao Guangrong > > > > It introduces a new statistic, pages-per-second, as bandwidth or mbps is > > not enough to measure the performance of posting pages out as we have > > compression, xbzrle, which can significantly reduce the amount of the > > data size, instead, pages-per-second is the one we want > > > > Signed-off-by: Xiao Guangrong > > --- > > hmp.c | 2 ++ I've queued this 1/3 and fixed these typos during the merge. Dave > > > +++ b/migration/migration.h > > @@ -126,6 +126,12 @@ struct MigrationState > > */ > > QemuSemaphore rate_limit_sem; > > > > + /* pages already send at the beggining of current interation */ > > beginning, iteration > > > + uint64_t iteration_initial_pages; > > + > > + /* pages transferred per second */ > > + double pages_per_second; > > + > > /* bytes already send at the beggining of current interation */ > > although you copied the existing typos > > > +++ b/qapi/migration.json > > @@ -41,6 +41,9 @@ > > # > > # @multifd-bytes: The number of bytes sent through multifd (since 3.0) > > # > > +# @pages-per-second: the number of memory pages transferred per second > > +# (Since 3.2) > > +# > > 3.2 was last year; you'll need to update your series to use 4.0 on all > new stuff > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK